Hyper: Unneccesary new version notification

[soleera]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: Hardened Gentoo (Linux kernel 4.9.24)
• Hyper.app version: 1.3.3
• Link of a Gist with the contents of your .hyper.js: .hyper.js
• Relevant information from devtools _(CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere)_: N/A
• The issue is reproducible in vanilla Hyper.app: Yes

Issue

When using hyper compiled from the 1.3.3 release source, a red notification window opens in the bottom right which says "Version 1.3.3 is available. Performance improvements 🚀", despite the fact that I am running version 1.3.3. This is not reproducible when using the AppImage.

[albinekb]

Did you download the source from the releases tab? see https://github.com/zeit/hyper/issues/1834

[soleera]

Yes, the .tar.gz one to be precise.

[soleera]

Ah, I just checked hyper-1.3.3/app/package.json and it has this:
"version": "1.3.2"
So it'll be the same issue as that one.

[Stanzilla]

Yeah, this issue https://github.com/zeit/hyper/issues/1818

[soleera]

Do we know if it's just the version tag that wasn't bumped, or is the code also from 1.3.2?

[albinekb]

Don't know actually 😄 this is not an issue with the built ones, so probably the code in the .tar.gz is 1.3.2

I'd recommend just running from master since there's a lot of unreleased fixes (release soon) 👍

[soleera]

I just checked, and if you look at the 1.3.3 tag the most recent commit is this, which immediately precedes the version bump commit here. So the fix would be to add the 1.3.3 tag to that version bump commit and then create a new 1.3.3 archive which includes it (or just sed the version tag in the source code before compiling =P); there shouldn't be any other code differences apart from that.

[mojoaxel]

I noticed a similar issue: I'm on 2.0.0-canary and getting the "Please update to 1.4.8" message.

[albinekb]

@mojoaxel if you downloaded the canary release from the releases, you need to update ~/.hyper.js to use canary channel, here's the issue for that: https://github.com/zeit/hyper/issues/2704

[chabou]

(original issue) Fixed in v2 🎉