Hyper: Underline cursor disappeared after upgrade to hyper 1.3.2

[ooJerryLeeoo]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: macOS sierra 10.12.4
• Hyper.app version: 1.3.2
• Link of a Gist with the contents of your .hyper.js: Here
• Relevant information from devtools _(CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere)_: N/A
• The issue is reproducible in vanilla Hyper.app: Is Vailla

Issue

The underline cursor disappeared after upgrade to hyper 1.3.2

[chabou]

Reproduced.
I've have a wrong height on cursor-node: 1397px (whatever window size is)

[slavapavlutin]

I have the same issue. In my case it seems like cursorNode height is calculated based on the baseline of scrollPort, which results in it being too large.

[samholmes]

Same issue.

[chabou]

You can temporaly fix it by adding this to your config:
termCSS: '.cursor-node{height:14px !important}',

[slavapavlutin]

@chabou where height equals your fontSize.

[chabou]

yes obv.
Thank you for this precision and for having precisely pointing the source of this regression.

[ryanlloydfrench]

Whoops, I just created an issue for this. Must have been writing the same time as you..

[bryantee]

With 'hyper-materialshell' plugin set, I can't see cursor as BLOCK or UNDERLINE, even with the fix @chabou suggested.

[jakewies]

Just noticed this today and came to open an issue. Originally thought it was something with the hyper-blink plugin. Will try the workaround 👍