Hyper: Cropped icon rendering with Powerline+Font Awesome font . 'Fix' with opening split panes.
- [x] I am on the latest Hyper.app version
- [x] I have searched the issues of this repo and believe that this is not a duplicate
- OS version and name: macOS Sierra 10.12.4
- Hyper.app version: 1.3.1.1628
- Link of a Gist with the contents of your .hyper.js: https://gist.github.com/paulklemm/5ee36a36930a7ba0a895f2bcdc8c915d
- Relevant information from devtools _(CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere)_: N/A
- The issue is reproducible in vanilla Hyper.app:
Is Vanilla
Issue
I'm using ZSH with the powerlevel9k theme and SourceCodePro+Powerline+Awesome Regular font (https://github.com/gabrielelana/awesome-terminal-fonts).
The icons are cropped in hyper.
When I open a new split pane horizontally, the problem disappears, while the new pane is still rendered wrong.
Opening a third one doesn't help.
If you, however, split horizontally, you can also get the opposing pane fixed.
paulklemm
All 31 comments
Same issue here, noticed it on the previous version as well.
fsegouin
on 10 May 2017
Update: Still relevant for 1.3.3.1754
paulklemm
on 31 May 2017
Any update on this?
fsegouin
on 15 Jun 2017
If it helps: I am using fish with the oh-my-fish/theme-bobthefish theme, as well as MesloLGS Nerd Font as hyper font.
fsegouin
on 22 Jun 2017
+1 also having the same 'icons cut off' issue. Using Zsh w/ InputMono Nerd Font. Also seeing a split fixing it in the original window.
sjoeboo
on 29 Jun 2017
I've now encountered this issue. ZSH, PowerLevel9K with FureCode Nerd Font
tomsturge
on 10 Jul 2017
Update:
Related issues I could find:
It seems that PR https://github.com/zeit/hyper/pull/1536 solves the problem. It was merged into master end of May and should therefore be in the next Hyper.js release.
🤞🏽
paulklemm
on 10 Jul 2017
@paulklemm AFAIK #1536 has been reverted in #1847
deiga
on 10 Jul 2017
@deiga You're right. Just compiled the current codebase and the problem still persists.
paulklemm
on 10 Jul 2017
The interesting thing is that it only happens when there is a background color.
With colored background:
With default color background:
lucasqueiroz
on 11 Jul 2017
@lucasqueiroz For me it's independent of the background color. Can you share your config?
paulklemm
on 11 Jul 2017
@lucasqueiroz The bug you mentioning has something to do with your theme, nothing is cropped out.
fsegouin
on 11 Jul 2017
It's not the theme. I've removed the theme, added again. It only works when there is no background color for the text.
lucasqueiroz
on 16 Jul 2017
Switched to iTerm as a result of this issue and it's working fine. Problem persists in Hyper with same config
Top: iTerm2
Bottom: Hyper
tomsturge
on 2 Aug 2017
Any progress on this issue? Still present in v1.4.3
tomsturge
on 9 Sep 2017
Seems like vscode terminal also has the same issue: https://github.com/Microsoft/vscode/issues/30289. Potentially issue upstream in xterm.js?
chhschou
on 13 Sep 2017
@chhschou is right, VS Code has the same problem:
paulklemm
on 14 Sep 2017
Any improvement on this issue?
Tabrizian
on 16 Sep 2017
mine works in vscode but have the same issue in Hyper
jobarbo
on 29 Sep 2017
For me, it has been fixed in 2.x
lucasqueiroz
on 29 Sep 2017
2.x ? isn't the last version 1.4.8?
jobarbo
on 29 Sep 2017
Check the prerelease section
On Sep 30, 2017, at 12:12 AM, jobarbo <[email protected]notifications@github.com> wrote:
2.x ? isn't the last version 1.4.8?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/zeit/hyper/issues/1769#issuecomment-333233943, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJoxV-mCE-GuP2IRW0MWDVPUIN80i3Etks5snVYigaJpZM4NKph1.
Tabrizian
on 29 Sep 2017
On Hyper v2.0.3, still not fixed:
However it did seem to have improved left prompt:
chhschou
on 30 Sep 2017
I believe this is a simple fix, we should be using the xterm-wide-char to display the powerline characters css class instead of xterm-normal-char. Changing to xterm-wide-char in devtools looks like this:
I believe this is fixed upstream in xterm.js. I don't know how is xterm.js changes applied in hyper to verify this theory atm.
chhschou
on 13 Oct 2017
Seems to be fixed as of 2.0.4 (might be related to the recent fix in xterm.js).
fsegouin
on 23 Oct 2017
@fsegouin It's partially fixed. I still experience problems as @chhschou describes. Some Icons are still cropped.
paulklemm
on 23 Oct 2017
Hey, 2.0.4 didn't fix it for me, what did work for me though was adding this to .hyper.js config file:
termCSS: 'x-row .unicode-node {display:inline}'
gabrieldrs
on 4 Jan 2018
@gabrieldrs Doing this seems to mess with the cursor, slightly offsetting it to the left when there are icons on the same line. Do you happen to know of any other fix for this?
PabiGamito
on 13 Feb 2018
Hey there, to verify if this is indeed a Hyper issue or upstream at https://github.com/xtermjs/xterm.js/ could you please test if another xterm.js powered terminal shows the same problem you are experiencing? I suggest using https://github.com/Microsoft/vscode for testing. Thanks!
Stanzilla
on 23 Apr 2018
@Stanzilla I was indeed experiencing the same issues in the vscode terminal. I have removed any icons to avoid this, so I haven't tested it since a bit after posting here.
PabiGamito
on 26 Apr 2018
Special indicators (like the branch icon and less noticeable the git dot) are cropped in 2.1.0-canary.1:
Surprisingly this is bugged in VSCode as well.
ghost
on 27 Apr 2018
Related issues
eoinmurray
·
3Comments
weabot
·
3Comments
alejandrofloresm
·
3Comments
laur1s
·
3Comments
stan-stripe
·
3Comments
Most helpful comment
Switched to iTerm as a result of this issue and it's working fine. Problem persists in Hyper with same config
Top: iTerm2
Bottom: Hyper