IMO, we should just restart automatically after downloading an update if no Hyper window is open.
leo
All 13 comments
This is really clever
rauchg
on 31 Dec 2016
As long as there is a notice I'm fine with that.
einfallstoll
on 1 Jan 2017
I wouldn't expect that to happen...
albinekb
on 4 Jan 2017
From the electron auto-updater docs:
Note: autoUpdater.quitAndInstall() will close all application windows first and only emit before-quit event on app after that. This is different from the normal quit event sequence.
If there is no window open, shouldn't quitAndInstall() just restart it? I mean, I would assume that that's the expected behavior, isn't it working like that right now?
pablopunk
on 7 Jan 2017
I prefer the macOS way. Give user the ability to update when they want.
ppot
on 8 Jan 2017
I like the Chrome way. Always run the _latest_, the least you bother the user the better.
rauchg
on 8 Jan 2017
I like the Chrome way. Always run the latest, the least you bother the user the better.
Thumbs up for that 馃檶馃徎
IMO for patches or even minor versions it should be automatic.
pablopunk
on 8 Jan 2017
Yep, in the case of no terminal sessions being open, for all cases I think
rauchg
on 8 Jan 2017
That would be great. How does the updating process work currently? Is it manual? I'm on Windows 10
AlbertoElias
on 9 Jan 2017
@rauchg is this issue valid yet? I started using Hyper a few days ago and I would like to contribute.
jhonnymoreira
on 2 Jun 2017
Yep, I'd say we're happy to accept a PR for it! 馃槉
leo
on 2 Jun 2017
thanks, @leo! Expect a PR soon. [=
jhonnymoreira
on 2 Jun 2017
Stanzilla
on 23 Jan 2018
Related issues
leo
路
3Comments
eoinmurray
路
3Comments
weabot
路
3Comments
rauchg
路
3Comments
alejandrofloresm
路
3Comments
Most helpful comment
I like the Chrome way. Always run the _latest_, the least you bother the user the better.