Hyper: Sluggish delete performance on Windows

[tiborsaas]

• [x] I am on the latest Hyper.app version

• [x] I have searched the issues of this repo and believe that this is not a duplicate

• Windows 10

• 1.0

Issue

Holding backspace does not always delete all text from the prompt.

[stefanivic]

@tiborsaas strange. Works fine for me.

[tiborsaas]

I know, sometimes it deletes everything, sometimes it doesn't. Not consistent.

[jonathanrdelgado]

I can replicate this issue, appears hyper sometimes becomes out of sync when using backspace and arrow keys.

This might be related to https://github.com/Microsoft/vscode/issues/7345

[styfle]

I also have this problem and it happens with arrow keys as well. What I see in the input and what shows up after I hit enter are not always the same.

Edit: I am using Git Bash as my shell.

[pfist]

I have this issue as well, but only when using Git Bash as my shell. When using cmd or PowerShell, delete works consistently as expected.

[Tyriar]

To confirm what @nkpfstr, I have only observed this on non-cmd/PS shells in VS Code. Likely related to https://github.com/zeit/hyper/issues/1127

[hfitzwater]

I've experienced this issue running cygwin bash. The same type of thing can happen when clearing the buffer.

[celevra]

i'Ve also experienced this with cygwin

[damien122]

OS version and name: windows 10 x64

Hyper.app version: 1.0.0

for me the same problem with git bash and cmd ... sometimes the last two or three chars are not deleted and then after pressing enter, they are not interpreted as a command. For hyper it is like you press enter on an empty line.

[ashelley]

Can confirm using "C:\Program Files\Git\bin\bash.exe" as my shell causes backspace to not work properly.

1) enter in long string of text into terminal
2) hold backspace

Expected results:

Back space deletes all characters

Actual results:

Position of cursor seems laggy and "bounces back" while deleting. End result is that you end up with a cursor position that it out of sync from what it should be and it looks like all text has not been deleted.

EDIT: and screen cap to show laggy bouncy behavior on backspace, at end of video you cannot backspace anymore meaning that the "jumps" while backspacing caused something to become out of sync

UPDATE:

Can confirm this is related to https://github.com/Microsoft/vscode/issues/7345 as the exact same thing happens there..

Steps to reproduce: You don't need to hold down back space... even taping it slowly can reproduce

Using redux dev tools I was able to record when things go awry for the terminal:

Everything is behaving good here, hit backspace... terminal behaves properly:

Next key stroke, hit backspace and then something looks strange with the SESSION_PTY_DATA data that comes back... (looks different than when typically hitting backspace)

It's hard to explain but here the full video of the interaction with the dev tools open showing SESSION_PTY_DATA going funky and corrupting the terminal display:

https://drive.google.com/open?id=0B8I56BZ3xez4ZHcxbzNzcTNTZDQ

[Tyriar]

This should be fixed in tomorrow's VS Code Insiders build using the beta build of node-pty. The next version of node-pty will include the long time coming winpty upgrade which fixes a host of issues (https://github.com/Microsoft/vscode/issues/14613 among others), so I'm just verifying the current build and then waiting on the fix for https://github.com/rprichard/winpty/issues/96 (which affects WSL/Bash on Windows) before I publish the new version :tada:

[martinsustek088]

I can confirm, that in Windows 1.9.0-insider build (commit 2c96...3f2f) in Git-bash shell backspace and left and right arrow keys works as it should.
With exception of unicode (multibyte) characters - they are displayed normally but for backspace/arrow keys they counts as multiple characters.