Hyper: Fira Code ligatures not showing

Created on 21 Oct 2016 · 30Comments · Source: vercel/hyper

After updating Hyperterm to 0.8.3 through homebrew cask, the Fira Code font's ligatures don't work, even though the font itself is being used
screen shot 2016-10-20 at 11 49 09 pm

In the above screenshot, the 0 especially gives away that FiraCode is being used and not Menlo.

screen shot 2016-10-20 at 11 51 50 pm

Yet as you can see from the arrow function above, the ligatures are not being used.

Source

ericmarkmartin

👍16

Most helpful comment

@ccorcos the relevant lines:

    // font family with optional fallbacks
    fontFamily: '"Fira Code", Menlo, "DejaVu Sans Mono", "Lucida Console", monospace',

and

    // custom css to embed in the terminal window
    termCSS: `
        x-screen x-row {
            font-variant-ligatures: initial;
        }
    `,

fczuardi on 2 Dec 2016

👍37 🎉12 ❤3

All 30 comments

This CSS will re-enable ligatures:

x-screen x-row { font-variant-ligatures: contextual; }

0x6c7862 on 21 Oct 2016

🎉19 👍19 😕1 😄1 👎1

FWIW, even if I add the CSS to Hyper's config (the css key), the x-row elements don't get that style. 🤔

wolverian on 21 Oct 2016

As suggested in another issue, I added the following to the configuration to make ligatures work. I am using Hasklig instead of Fira Code, though, but I expect the font not to be the issue.

screen shot 2016-10-21 at 12 31 23

dak0rn on 21 Oct 2016

👍5

definitely a bug, but also a dup #874

iamstarkov on 21 Oct 2016

Thanks for the replies. Unfortunately I didn't see that issue since because it was marked closed, not a bug, and didn't contain the word Fira.

ericmarkmartin on 22 Oct 2016

Thanks for the workaround, @0x6c7862 and @dak0rn ! Works great for now.

I didn't see any code in this repo explicitly turning them off so my guess is that a dependency upstream somewhere changed and broke this behavior.

I'd vote for ligatures being enabled by default unless there's a good reason not to. People coming to a terminal based on JS, HTML, and CSS will expect ligatures to work out of the box.

mjswensen on 24 Oct 2016

👍25 🎉3

Hmm. I wasn't able to get it to work:

ccorcos on 1 Dec 2016

@ccorcos the relevant lines:

    // font family with optional fallbacks
    fontFamily: '"Fira Code", Menlo, "DejaVu Sans Mono", "Lucida Console", monospace',

and

    // custom css to embed in the terminal window
    termCSS: `
        x-screen x-row {
            font-variant-ligatures: initial;
        }
    `,

fczuardi on 2 Dec 2016

👍37 🎉12 ❤3

wait, now its working! :)

ccorcos on 2 Dec 2016

Is it posible to add a simple boolean option to trigger this feature?

gluons on 21 Feb 2017

👍5

enableLigatures pls :D

thasmo on 25 Feb 2017

👍14

It is @gluons

matheuss on 25 Feb 2017

👍2

Just curious; why are ligatures disabled by default? Is there an inherent overhead?

Qix- on 12 May 2017

👍4

Just published https://github.com/timneutkens/hyper-ligatures. Guess we can close the issue 👍

timneutkens on 23 Jul 2017

👍6

@timneutkens Just fyi (you probably already saw, but for completeness sake). As Hyper v2 uses a different terminal emulation, that is using different tags/classNames as rows, there should be a change to your plugin to accommodate for this. (I created a PR on your repo with the changes I think are necessary to support the new implementation as well).

:smile:

fleischie on 26 Sep 2017

@timneutkens this will break in future updates of hyper. (More exactly, when we change to xterm 3, based on canvas) you should state that in your readme 👍