Hyper: Prompt before closing the app when a process is running

[tleunen]

Related to #623. Would it be possible to have a prompt before quitting the app when a process is running? It could help to prevent quitting the app with an ongoing process that we won't be able to kill without manually killing the PID.

[vitorbal]

Hi there! I would like to take a stab at this feature if possible.

I've already managed to hook up to the window close event and display a prompt to the user, but I'm having a bit of trouble figuring out how to determine if there is an ongoing process in a tab.
Could someone point me in the right direction?

Sorry if it's a silly question, this is my first time contributing to hyperterm. Thank you for the project, having a blast using it! :)

[NicholasWalton]

Perhaps take a look at how gnome-terminal does it?
https://github.com/linuxmint/gnome-terminal/blob/master/src/terminal-screen.c#L2083

[TylerRick]

I was just going to open an issue for this and ran across this one. :smile:

Particularly since I'm not used to Ctrl-W closing the tab (except in web browser), I've already been bit by this a number of times and :zap: lost all of the processes I had running in a window that I accidentally closed. Would love to see this one implemented. :+1:

I was going to suggest the exact same thing as @NicholasWalton: Perhaps take a look at how gnome-terminal does it... Their prompt looks like this:

[kaushik-asp]

Still open?

[kevin-bebel]

Hi,

Is this Feature still available to work on?

[jpolack]

Would interest me aswell

[diogotorres97]

@kevin-bebel and @jpolack, you could look to my PR and add some fixes!

https://github.com/zeit/hyper/pull/2477

[jackHedaya]

Looks like the PR is stale. I'm going to give this a shot myself.

[rohitkrishna094]

So any updates on this? I need this feature as a temporary solution for #623. Did the corresponding PR for this get merged? If yes, how to enable it in hyper? Thanks

[Nevnet99]

Nowhere near finished still trying to fix a bug that has been nagging me for a few hours anybody knows of anywhere to look? https://github.com/Nevnet99/hyper/tree/bugfix/ISSUE-684 will be picking this up again a little later :) also still trying to look for the function that fires on close of the terminal.

TODO:

• Find the solution to check if a process is running.
• Make popup appear on the mass closure of the terminals.

[Nevnet99]

Struggled with this the entire day didnt get any further ;(

[Project-Magenta]

I'm willing to do this for Hacktoberfest. Is this still available?

[jackHedaya]

@Project-Magenta Took a crack at it ages ago and didn't really get anywhere. Go ahead!

[Picoseconds]

Are we willing to introduce a new dependency of ps-node?

[Project-Magenta]

oh, btw Picoseconds is also me

[Picoseconds]

@lucleray can you add hacktoberfest tag so I can get a tshirt?