Hydrogen: Use Atoms Docks API for our panels

Created on 21 May 2017  路  3Comments  路  Source: nteract/hydrogen

Atom 1.17 introduced a new docks API (Used by the tree view, GitHub and Linter packages).
We should use it as well. This will allow us better work in conjunction with other packages and makes our panels more flexible.

  • [x] Inspector
    We should do this first since it's simpler to implement with less refactorings and we can get rid react-resizable-box then.
  • [x] Watch Sidebar

Relevent resources:

Example PRs from other projects:

enhancement mozsprint

Most helpful comment

I will start working on this issue. I think we should ship a release before we finish this due to the atom v1.17 dependency. This way holdouts can still get the new result and watch-views!

All 3 comments

I will start working on this issue. I think we should ship a release before we finish this due to the atom v1.17 dependency. This way holdouts can still get the new result and watch-views!

Even more information on the Atom blog: http://blog.atom.io/2017/05/23/docks-deep-dive.html

I refactored the Watch Sidebar as a react component so we can easily use it in a dock.
@BenRussert I'd happy to pair with you in the next few days and move our panels to docks.

Was this page helpful?
0 / 5 - 0 ratings