Hugo: Upgrade to Blackfriday v2

[bep]

https://github.com/russross/blackfriday/releases/tag/v2.0.0

[vassudanagunta]

More flexibility for custom renderers and access to the syntax tree will be huge! I have been working on something for Hugo that could use both of these features.

[bep]

@chaseadamsio part of me wanted to jump on this so I just pulled in v2 to get a sense of the scope of everything. And I notice that goorgeous is using the BF renderer -- which is great news in the long run of it all (think ToC support etc.) , but that means that we should update that library as part of this task. And it would be great if we could do a dugnad on this ... some time. Where you could potentially create a v2 branch of your project or something ...

[chaseadamsio]

👍 I can try and do that sometime this week. https://github.com/chaseadamsio/goorgeous/pull/69 v2.0.0 in the pipeline.

[chaseadamsio]

@bep: https://github.com/chaseadamsio/goorgeous/tree/v2.0.0

Ran tests locally and in Travis with 2.0.0, everything looks seamless, I'm testing with my hugo install locally just to double check. Do you want me to PR the version bump (along with the blackfriday bump) or do you want to do it?

[bep]

. Do you want me to PR the version bump (along with the blackfriday bump) or do you want to do it?

I will do tit as part of a "bigger scope". Do you mean that you were able to pull in the BF v2 without any code changes?

[chaseadamsio]

@bep that's correct. I checked out BF v2 locally and ran tests, added it as a go dependency to goorgeous and did a sanity that the HTMLRenderer signature that goorgeous uses from BlackFriday hasn't changed and sanitied methods that goorgeous is calling to make sure the API hasn't changed. Goorgeous is compatible with BF v2. Since there's a hard dependency on it, I went ahead and cut a 2.0.0 version of goorgeous in case the API does change.

[Nodraak]

Hi! What's the status of this? Why was PR #3994 closed without merging?

ping @bep :)

[dwy6626]

I need this to solve the hard linebreak issue:
https://github.com/russross/blackfriday/issues/307