Hugo-theme-zzo: Favicon only works when there is favicon.png

[nisrulz]

I noticed favicon change only works with favicon.png. I had favicon.ico and it wouldn't pick it up, unless I added favicon.png.

Ideally it should pick .ico first and then .png.

[zzossig]

Yes, you are right. It should be fixed!

[nisrulz]

I could take a look!

[zzossig]

I tested it. but .ico file seems to work well.
What browser are you using? what Hugo version?
macOS or Windows10?

[nisrulz]

Ubuntu Budgie 18.0.4 LTS

Chrome: Version 79.0.3945.88 (Official Build) (64-bit)

Hugo Static Site Generator v0.62.0/extended linux/amd64

Make sure you don't have the favicon.png file. This is when it doesn't pickup the .ico file.

[zzossig]

I didn't test it on the Ubuntu environment.
But in windows10, it works fine even though the favicon.png file does not exist.
I'll test it on Ubuntu soon

[nisrulz]

I could try on a Macbook Air, I have one. I will add my findings here too!

Thank you!

[zzossig]

I tested it on Ubuntu but seems to work well.
Did you try to force reload the browser?
ctrl + shift + r

[nisrulz]

I updated the git submodule and now everything works.Weird. :thinking:

Anyways, looks like it is fixed. So we can close this issue.

Thank you!