hub pull-request has trouble understanding editor variable

[ElDeveloper]

My ~/.gitconfig has the following in it (among many other things):

[core]
    editor = vim -u ~/.vimrc-mutt +startinsert

However, this makes hub pull-request fail with the following message:

error using text editor for pull request message

It works just fine when I change it to:

[core]
    editor = vim

[mislav]

Thanks for letting us know! We'll look into it. In the meantime you could try setting GIT_EDITOR=vim hub pull-request whenever you're making a PR, so you don't have to constantly change your original ~/.gitconfig.

[mislav]

Hi, I can't reproduce this. Can you confirm that you're using latest release hub 2.2.1? If not, please update.

Also, which platform are you on?

[ElDeveloper]

I was able to confirm this is no longer a problem with 2.2.1, must have been a problem with 1.12.4.

[mislav]

Thank you!

[coaxial]

I just ran into this issue, this is my .gitconfig:

[core]
  editor = $(which vim)

And I'm getting the same error message when running git pull-request: error using text editor for pull request message

git commit opens vim just fine.

$ hub version
git version 2.6.4
hub version 2.2.2

[dougludlow]

I got this error on Windows 10.

> hub version
git version 1.9.5.msysgit.0
hub version 2.2.3

But I found I was missing the core.editor setting. So I ran git config --global core.editor vim and was good to go.

[scottbasgaard]

Thanks @dougludlow

[shawwn]

I'm getting problems with hub.protocol=https core.editor=gvim --remote-wait

hub pull-request doesn't seem happy about that core.editor setting.