Httpx: Is it planned to implement __bool__ on Response?
The same way it's done on requests.
I saw that response.is_error is available, I was wondering if it was planned or not (as I was considering httpx some kind of drop-in replacement for requests)?
Thanks again
question
Colin-b
All 2 comments
Nope, I doubt we’d do that.
tomchristie
on 10 Feb 2020
👍2
I'm inclined towards a "no" too, basically for the same reason we don't have response.ok: ambiguous — and in this case, possibly error-prone.
(Eg. if you use if not response: ... would that be to check whether response is set, or whether the response is "falsy"? What would "falsy" mean? response.is_error? Then we should access this attribute explicitly.)
florimondmanca
on 10 Feb 2020
👍2
Was this page helpful?
0 / 5 - 0 ratings
Related issues
x0day
·
4Comments
edocod1
·
3Comments
njsmith
·
3Comments
kde713
·
3Comments
szelenka
·
4Comments
Most helpful comment
I'm inclined towards a "no" too, basically for the same reason we don't have
response.ok: ambiguous — and in this case, possibly error-prone.(Eg. if you use
if not response: ...would that be to check whetherresponseis set, or whether the response is "falsy"? What would "falsy" mean?response.is_error? Then we should access this attribute explicitly.)