Httpx: Handle HEAD responses with Brotli decoder
Currently if you receive a response with Content-Encoding: br set and no body we get an error because Brotli doesn't like being called on an empty stream.
sethmlarson
All 2 comments
More generally: we should make sure not to call any decoder if the body is empty.
tomchristie
on 19 Aug 2019
On reviewing #237 I think we should just call into the decoders, but that we should just make sure that all the decoder implementations correctly handle b"" input, and all correctly return b"" outputs in that case.
Ideally a test case for this issue would be parameterized to ensure correct behavior here from all our decoder classes.
tomchristie
on 19 Aug 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings
Related issues
edocod1
路
3Comments
szelenka
路
4Comments
x0day
路
4Comments
tomchristie
路
3Comments
njsmith
路
3Comments
Most helpful comment
On reviewing #237 I think we should just call into the decoders, but that we should just make sure that all the decoder implementations correctly handle
b""input, and all correctly returnb""outputs in that case.Ideally a test case for this issue would be parameterized to ensure correct behavior here from all our decoder classes.