Https-everywhere: Only run ruleset tests for ruleset changes

Created on 19 Jul 2019  路  6Comments  路  Source: EFForg/https-everywhere

Type: feature request

Oftentimes, the travis tests fail for something that is totally unrelated to the changes in the PR. This can create confusion for new contributors, especially if they're new to GitHub and continuous integration.

It would be nice to have a way to only run validations, fetch, and preloaded tests when the only changes concern rules.

I don't think this would have any security implications but I need to think about it more.

question ruleset-testing

Most helpful comment

@pipboy96 it will be a top priority to separate the extension from the rulesets in the next year or so.

All 6 comments

I hope someday repos and the extension code will have separate Git repos. I feel like this is not going to happen any time soon though.

I think fetch test is not triggered unless at least one ruleset file had been added or changed.

@pipboy96 it will be a top priority to separate the extension from the rulesets in the next year or so.

I think fetch test is not triggered unless at least one ruleset file had been added or changed.

This was definitely true in the past, but appears not to be the case anymore.

https://github.com/EFForg/https-everywhere/blob/master/test/run_travis.sh#L69

Here, ONLY_RULESETS_CHANGED is set but never used. It shouldn't be difficult to auto-pass the non-ruleset tests if only rulesets have been changed.

@Hainish Should I make a PR to fix it?

Thanks, that would be great!

Was this page helpful?
0 / 5 - 0 ratings