Https-everywhere: Test if test url is covered by any target

Created on 14 Jan 2018  路  5Comments  路  Source: EFForg/https-everywhere

Test urls with hosts not related to any target are currently allowed in rulesets.
The following scenario should should fail in ruleset tests:

<ruleset name="example">
    <target host="target.example" />

    <test url="http://no-target.example/" />

    <rule from="^http:" to="https:" />
</ruleset>

Type: other

ruleset-testing

Most helpful comment

@cschanaj this should be fixed with 7f4fe7c8547aa7dabb0762c268b8b67857b91182, thanks for alerting me to this.

All 5 comments

This might be challenging to check completely, for example for a wildcard target with a very complex rule.

Have you seen rulesets like this in the wild?

One example has been fixed here: #14177

Submitted a PR in #14293 (not really sure if I have the implementation correct.. though)

@Hainish there is something wrong with Travis chrome-beta and chrome-stable since https://github.com/EFForg/https-everywhere/commit/d36ea408818d865966b8cd632b065a1f1b5a88fc. Would you mind to take a look?

@cschanaj looking now

@cschanaj this should be fixed with 7f4fe7c8547aa7dabb0762c268b8b67857b91182, thanks for alerting me to this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

austin987 picture austin987  路  5Comments

a0193143 picture a0193143  路  4Comments

cschanaj picture cschanaj  路  3Comments

J0WI picture J0WI  路  4Comments

the8472 picture the8472  路  4Comments