Http4s: ListSep in Rfc2616BasicRules does not conform to RFC

Created on 24 Aug 2020  路  4Comments  路  Source: http4s/http4s

An initial conversation: https://gitter.im/http4s/http4s-dev?at=5f056255dbf01050ab5e7a14

In short, currently ListSep is defined as follows:

def ListSep: Rule0 = rule(oneOrMore("," ~ OptWS))

while a correct definition would look something like:

def ListSep: Rule0 = rule(OptWS ~ ',' ~ OptWS))

See also:

bug
Source
picture satorg

All 4 comments

I can tackle this bug, if it looks like something a relative newcomer to the project can do

jyoo980 picture jyoo980 on 25 Aug 2020
👍1

@jyoo980, sorry, I decided to overtake you with this issue.

satorg picture satorg on 14 Oct 2020

@satorg totally my bad, thanks for resolving this! 馃憤

jyoo980 picture jyoo980 on 14 Oct 2020

I guess we can close this issue, cannot we?

satorg picture satorg on 20 Oct 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

reactormonk picture reactormonk  路  5Comments
rossabaker picture rossabaker  路  4Comments
reactormonk picture reactormonk  路  3Comments
rossabaker picture rossabaker  路  9Comments
mblaze picture mblaze  路  7Comments