Html-webpack-plugin: html-webpack-link-type-plugin should be native functionality

Created on 3 May 2019  路  4Comments  路  Source: jantimon/html-webpack-plugin

Is your feature request related to a problem? Please describe.
html-webpack-link-type-plugin inserts the correct MIME types for injected links.
This should be a core functionality of HTMLWebpackPlugin, seeing as how...

  1. It doesn't make much sense not to inject correct MIME types, and an option could still allow old behavior. It could be considered a bug that HTMLWebpackPlugin does not do this currently.

  2. I feel extremely uncomfortable using a package maintained by a single individual, with 0 stars on Github and less than 200 weekly NPM downloads, in a production environment. Especially when it provides such simple functionality. This is a security concern if nothing else.

Describe the solution you'd like
Merge the code from html-webpack-link-type-plugin into HTMLWebpackPlugin

Describe alternatives you've considered
Alternatively, the html-webpack-link-type-plugin repository could be moved under @jantimon to quell security concerns over using a random unsupported package from a single individual in a production environment. The package is already listed under the README so I assume HTMLWebpackPlugin recommends use of this plugin.

I don't mind doing it myself if I get the green light from the package maintainers.

All 4 comments

I see what you mean but unfortunately that's how open-source works.
You can fork a repository like html-webpack-link-type-plugin and maintain it by yourself anytime.

At least html-webpack-plugins are usually very small for example the html-webpack-link-type-plugin/blob/develop/src/plugin.ts you mentioned has only 80 lines of code.

Why do you still need the mime type in 2019?

I was having issues where NGINX stopped serving up MIME types for css files and was looking into hardcoding them with webpack but after a while I discovered it was a relative include not resolving correctly in my configuration.

So I don't need this plugin, but I just felt while reviewing it that it should be a native part of HtmlWebpackPlugin. If you don't think it needs to be included feel free to close this issue.

@soulofmischief if it makes you feel any better, The reason that plugin exists is that there was an issue (#726 ) a few months ago requesting this functionality, and the resolution was to use the plugin hooks. We needed these MIME types for IE support, and so I spent a little time to spin this up.

I don't disagree with @jantimon that the html-webpack-plugin should offer the minimum for its purpose, and am thankful for the addons system. Luckily, while a project with a single maintainer (on github, its technically owned by the company I work for) is scary, its a pretty small repo, and you can (and did, I saw the PRs) read the whole thing pretty wuick to make sure I'm not mining bitcoins from your build or anything.

On a more selfish note, if you like the plugin, and want to make it less scary to others, feel free to give us that inaugural star on the repo.

That's a good suggestion, I've starred the project. Thanks for clearing that up guys, I'll go ahead and close the issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

var-bp picture var-bp  路  3Comments

klinki picture klinki  路  3Comments

yyx990803 picture yyx990803  路  4Comments

lonelyclick picture lonelyclick  路  3Comments

lcxfs1991 picture lcxfs1991  路  4Comments