Html-webpack-plugin: AppCache injection doesnt respect publicPath

[ccorcos]

I'm using the appcache plugin:

                new AppCachePlugin({
                    cache: appCacheAssets,
                    network: ["*"],
                    fallback: ["/"],
                    settings: [],
                    exclude: [],
                    output: "index.appcache",
                }),

Along with the this html plugin:

                new HtmlWebpackPlugin({
                    template: "./src/client/index.template",
                    config: config,
                }),

My output section specifies a public path:

        output: {
            filename: output,
            path: outputPath,
            chunkFilename: "[name]-[chunkhash].js",
            pathinfo: true,
            publicPath: "/",
        },

But that publicPath is not respected when the appcache file is injected :(

[mastilver]

@ccorcos Can you be clearer on how the publicPath is not respected

A repository reproducing the error would be helpful!

[ccorcos]

As requested: https://github.com/ccorcos/public-path-issue

[jantimon]

@ccorcos that's correct it should be prepended (probably here):

https://github.com/jantimon/html-webpack-plugin/blob/master/index.js#L411-L413

Fixing this would be a breaking change so we should add it to 3.x

[ccorcos]

Awesome. Just created a PR https://github.com/jantimon/html-webpack-plugin/pull/710

[stale[bot]]

This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days.

[lock[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.