Hotchocolate: Memory Consumption of Hot Chocolate

[traitmmm]

hello.
Today we did a small performance testing for HotChocolate in our simple project.
We generated around ~12mb of data.

My question: do you have any guesses how to improve current situation? because we have gap between Rest-like API and GraphQL Engine.

results:
DotTrace snapshot: https://www.dropbox.com/s/ojp9n8y2wb0dwyh/LineByLine.dtp?dl=0

p.s. do not worry about 42 sec, such results because we ran project under profiling.

[michaelstaib]

We are working in this at the moment. The issue is how we build up the result. In our current experiments the memory consumptions is reduced by 90%.

[michaelstaib]

You should retest end of the week with 10.4.0 rc.1

[traitmmm]

Hello,

Thanks we will try to do it on the next week, and I will provide feedback.

[traitmmm]

Hello @michaelstaib
Did you release 10.4.0-rc1 ?

[michaelstaib]

No,

this is the pr to watch: https://github.com/ChilliCream/hotchocolate/pull/1451

We also have decided to only fix this in version 11 since it has quite an impact.

There is still more work that we will do here. We so far have optimized around the result memory consumption which now is OK.

However, we are still working the execution new execution engine which will come later and is not included in this PR.

So,

when profiling the execution engine is still creating a lot of Tasks and ResolverContext objects.

The new execution engine will switch to ValueTask for the resolvers and introduce pooled ResolverContext objects.

[michaelstaib]

P.S. PR #1451 also switches the result serialization from JSON.NET to System.Text.JSON.

[traitmmm]

Perfect, thanks for fast update!

[michaelstaib]

I put this on the 11 backlog ... we will soon merge the pr after we have finished of version 10.4 so have a couple days more patience. This is high on our list.