Horizon: Move secrets out of config.toml

Created on 14 Jun 2016  路  3Comments  路  Source: rethinkdb/horizon

It seems reasonable to be able to commit your config.toml file to source control, since configuration is part of your app. But you can't because it has secrets in it. I propose we move secrets out to something like secrets.toml, do all the permissions stuff we do now on config.toml, and add do #454 with a .gitignore that prevents it from being checked in.

cli tool

Most helpful comment

+1 for moving them out. IMO secrets.toml is better than config.secrets.toml and plenty clear.

All 3 comments

Could we name the file config.secrets.toml, so it's clear they're secrets related to config.toml?

+1 for moving them out. IMO secrets.toml is better than config.secrets.toml and plenty clear.

This is done in 2.0.0

Was this page helpful?
0 / 5 - 0 ratings

Related issues

intellix picture intellix  路  5Comments

dalanmiller picture dalanmiller  路  7Comments

hnordt picture hnordt  路  9Comments

hnordt picture hnordt  路  7Comments

stellanhaglund picture stellanhaglund  路  5Comments