In the Device Registry Management API, the fields in the Device JSON structure related to the gateway groups feature are defined in camel-case notation:
"viaGroups": [
"string"
],
"memberOf": [
"string"
],
However, in the other parts of the API, the kebab-case notation is used (e.g. auth-id, minimum-message-size, resource-limits, etc.).
Not sure what the raised thumbs are supposed to be indicating. In any case I would be in favor to consistently use kebab-case, i.e. change viaGroups to via-groups and memberOf to member-of. We need to be careful, though, to not introduce a breaking API change since this affects public API ...
So my :+1: was for fixing the inconsistency by using "kebab-case".
Some additional thoughts from my side: We should also look at the other Eclipse IoT projects and their API definition. Among others Eclipse Ditto is of interest because of our Eclipse IoT Packages and they are following camel-case notation (see for example https://www.eclipse.org/ditto/http-api-doc.html#/Things/get_things__thingId_).
From my perspective we should coordinate and go for a consistent approach. WDYT? @thjaeckle: Any thoughts from your side?
@mhemmeter yes, Ditto uses camel case in its JSON formats. And having that as public released API, we can't change this.
So from my point of view when we want to have consistent apis in scope of Eclipse IoT Packages, newly added apis should also be on camel case 馃槈
From my perspective it is important that we are consistent across the projects to improve UX and bring Eclipse IoT forward as a whole. So the community should at least decide on the preferred way for the future. It was important for me to bring this up here as the discussion was going in the direction of kebab-case.
When we will be consistent is another question but indeed we probably end up with a new major version of the APIs - may it be in Eclipse Hono or Eclipse Ditto.
From my perspective it is important that we are consistent across the projects to improve UX and bring Eclipse IoT forward as a whole.
I disagree in the way that this isn't important enough to break already existing APIs.
Built applications on top of that API would have to change "just because" we now like kebap better than camel case (for example, or the other way around).
Newly added APIs should be IMO
tenantId and deviceId camel cased: https://www.eclipse.org/hono/docs/api/management/#/devices)
Most helpful comment
So my :+1: was for fixing the inconsistency by using "kebab-case".