Hono: Device Registry REST API: "enabled" field cannot be created/updated via POST/PUT request with urlencoded form data input

[calohmn]

When trying to create/update device registration data that has "enabled" set to "false", there is a 400 "bad request" response if the request was made with urlencoded form data input.

Example:
curl -i -X POST -d device_id=4711 -d enabled=false http://127.0.0.1:8080/registration/DEFAULT_TENANT

Internally there is a "ClassCastException: String cannot be cast to Boolean" in BaseRegistrationService.getRequestPayload().

[calohmn]

See unit test methods testAddDisabledDeviceUsingFormData() and testUpdateDeviceWithDisablingDeviceUsingFormData() introduced in PR #317 (annotated with @Ignore there for now).

[sophokles73]

The underlying problem seems to be that the service class has no clue about the type of the properties provided in form fields. Consequently, fixing the problem reported in this issue by assuming that a property called enabled is of type boolean will help much in general, i.e. we are facing the same problem with additional properties to be registered with the device as well.
Thus, I would rather propose to restrict the payload format to JSON only.
WDYT?

[calohmn]

Yes, I'd be ok with removing formdata support.
Leads to a more consistent API with just one input/output data format.

[sophokles73]

@dejanb @ppatierno @pellmann @sysexcontrol
any opinion on this? I would like to remove the form encoded parameter passing in the REST adapter altogether. WDYT?

[ppatierno]

@sophokles73 absolutely fine for me, more consistent API is better ;)

[sophokles73]

fixed in 70c8d00941d8db8537a5cd43e2506910ab23a8a6