Homebrew-core: Remove old fixes/workarounds

Created on 19 Nov 2020 · 2Comments · Source: Homebrew/homebrew-core

Over time, we tend to keep in formulas some "workarounds" or fixes for old versions of OS or Xcode, that are not longer needed anymore.

Examples I can think of are:

Passing gl_cv_func_ftello_works=yes to configure, which is not needed since Catalina 10.15.1 (it was libc issue in the .0 macOS release)
Adding -fno-stack-check to CFLAGS, which used to work around an Xcode 10.0 compiler bug that was fixed in later Xcode versions

These should probably be removed, but it takes time to create these pull requests (ideally separate pull requests for each formula, to avoid opportunistic linking if we touch many formulas at once). Help wanted!

help wanted

Source

fxcoudert

Most helpful comment

I've removed mentioned workarounds manually, and then have created a bunch of PRs with the script:

#! /usr/bin/env bash

set -x

pushd $(brew --repo homebrew/homebrew-core)

for f in coreutils findutils gawk gettext gnu-sed gnu-tar gnutls lftp wget; do
    git checkout -b "remove-old-workaround-$f"
    git add "Formula/$f.rb"
    git commit -m "$f: remove gl_cv_func_ftello_works=yes workaround"
    git push -u fork
    gh pr create --title "$f: remove gl_cv_func_ftello_works=yes workaround" --body "See https://github.com/Homebrew/homebrew-core/issues/65180"
    git checkout master
done

for f in ansible [email protected] aom azure-cli erlang@20 ghc git-delta guile guile@2 libtommath mpg123 openttd ufraw x265; do
    git checkout -b "remove-old-workaround-$f"
    git add "Formula/$f.rb"
    git commit -m "$f: remove -fno-stack-check workaround"
    git push -u fork
    gh pr create --title "$f: remove -fno-stack-check workaround" --body "See https://github.com/Homebrew/homebrew-core/issues/65180"
    git checkout master
done

popd

bayandin on 19 Nov 2020

❤1 😄1

All 2 comments

I've removed mentioned workarounds manually, and then have created a bunch of PRs with the script:

#! /usr/bin/env bash

set -x

pushd $(brew --repo homebrew/homebrew-core)

for f in coreutils findutils gawk gettext gnu-sed gnu-tar gnutls lftp wget; do
    git checkout -b "remove-old-workaround-$f"
    git add "Formula/$f.rb"
    git commit -m "$f: remove gl_cv_func_ftello_works=yes workaround"
    git push -u fork
    gh pr create --title "$f: remove gl_cv_func_ftello_works=yes workaround" --body "See https://github.com/Homebrew/homebrew-core/issues/65180"
    git checkout master
done

for f in ansible [email protected] aom azure-cli erlang@20 ghc git-delta guile guile@2 libtommath mpg123 openttd ufraw x265; do
    git checkout -b "remove-old-workaround-$f"
    git add "Formula/$f.rb"
    git commit -m "$f: remove -fno-stack-check workaround"
    git push -u fork
    gh pr create --title "$f: remove -fno-stack-check workaround" --body "See https://github.com/Homebrew/homebrew-core/issues/65180"
    git checkout master
done

popd

bayandin on 19 Nov 2020

❤1 😄1

Thank for the help! I'll close this now

fxcoudert on 20 Nov 2020

Was this page helpful?

0 / 5 - 0 ratings