Homebrew-core: openjdk@8 migration tracking issue

Created on 22 Oct 2020  路  9Comments  路  Source: Homebrew/homebrew-core

Now that openjdk@8 can be installed as a formula, we should start migrating our current formulae that depends_on java: "1.8" to use depends_on "openjdk@8" instead.

This is part of our long-term goal to remove all cask Requirements from Homebrew/core, which will help speed up our CI deployment time. Once this is complete the only cask Requirements remaining would be osxfuse and xquartz.

General guidelines:

  1. revision bump
  2. depends_on java: "1.8" => depends_on "openjdk@8"
  • [x] amdatu-bootstrap
  • [x] apache-drill
  • [x] apache-flink
  • [x] apache-geode
  • [x] app-engine-java
  • [x] avian
  • [x] aws-apigateway-importer
  • [x] ballerina
  • [x] bee
  • [x] blazegraph
  • [x] cassandra-reaper
  • [x] ceylon
  • [x] clojure-lsp
  • [x] confluent-platform
  • [x] couchdb-lucene
  • [x] cypher-shell
  • [x] digdag
  • [ ] drip deprecated
  • [ ] druid deprecated
  • [x] elasticsearch@6
  • [x] embulk
  • [x] glassfish
  • [x] gosu
  • [x] grakn
  • [ ] groovyserv
  • [ ] henplus
  • [x] hexgui
  • [x] hive
  • [ ] infer deprecated (but see https://github.com/Homebrew/homebrew-core/pull/62862)
  • [x] javarepl
  • [x] jing-trang
  • [x] jmxterm
  • [x] jmxtrans
  • [ ] jooby-bootstrap
  • [x] jvm-mon
  • [x] jvmtop
  • [x] kafka
  • [x] kettle
  • [x] libreadline-java
  • [x] logstash
  • [x] maxwell
  • [x] mesos
  • [ ] nailgun deprecated
  • [ ] opentsdb deprecated
  • [x] payara
  • [x] pdftk-java
  • [x] pillar
  • [x] predictionio
  • [x] [email protected]
  • [x] [email protected]
  • [x] scm-manager
  • [x] swagger-codegen@2
  • [x] voldemort
  • [x] wartremover
  • [ ] yeti deprecated
  • [x] zanata-client
help wanted

Most helpful comment

Given https://github.com/Homebrew/brew/issues/9194 we're just gonna start skipping these on CI and eventually remove them entirely once JavaRequirements are totally gone from Homebrew/core. When our old CI gets shut down, the Mojave and Catalina virtual machines on the new CI runners will no longer have any Casks preinstalled at all.

Now that https://github.com/Homebrew/homebrew-core/pull/64659 and https://github.com/Homebrew/homebrew-core/pull/64662 are merged, I consider this to be finished 馃殌

Thanks to @hyuraku, @mattrussi, @Moisan, @samford, and especially @abl123 (their first-ever contributions on GitHub!) for helping to migrate these formulae, and @bayandin, @chenrui333 and @SMillerDev for helping to review and test pull requests!

All 9 comments

I couldn't get avian to work with openjdk@8 and their homepage states

PLEASE NOTE: This project is not currently being developed, maintained, or supported.

Should we deprecate it?

Yes we should

I would block further migrations since openjdk@8 is broken, see https://github.com/Homebrew/homebrew-core/pull/64536

Since it would install from a bottle that doesn't block migrating to it.

It would not install from a bottle on Linux / linuxbrew.

A couple things would help here:

  1. A better way to get the source code of a single tag for the entire set of jdk8u repositories, that doesn't rely on the whatever versions of bzip2 libraries (or whatever reason the checksum changed) that the jdk.net server uses.
  2. Fixing the build on Linux so we can test it there (see https://github.com/Homebrew/linuxbrew-core/pull/21317)

This migration needs to happen basically asap because the Homebrew maintainers have a ton of stuff to work on with Big Sur coming out, and having untested Requirements still remaining in Homebrew/core is going to cause headaches. Linux might get left behind a bit, but that's just how it is given the low volume of contributors and maintainers on Linux.

https://github.com/Homebrew/homebrew-core/pull/64659 has all test failures.
https://github.com/Homebrew/homebrew-core/pull/64662 has build and/or test failures.

I'm not intending on having the adoptopenjdk8 cask on big sur so these will have to be fixed or left behind.

@jonchang https://github.com/Homebrew/brew/pull/9208 is worth a note, too. /usr/libexec/java_home has stopped working on Big Sur so I think we're probably in "deprecate and remove the formulae that don't build" territory soon.

Given https://github.com/Homebrew/brew/issues/9194 we're just gonna start skipping these on CI and eventually remove them entirely once JavaRequirements are totally gone from Homebrew/core. When our old CI gets shut down, the Mojave and Catalina virtual machines on the new CI runners will no longer have any Casks preinstalled at all.

Now that https://github.com/Homebrew/homebrew-core/pull/64659 and https://github.com/Homebrew/homebrew-core/pull/64662 are merged, I consider this to be finished 馃殌

Thanks to @hyuraku, @mattrussi, @Moisan, @samford, and especially @abl123 (their first-ever contributions on GitHub!) for helping to migrate these formulae, and @bayandin, @chenrui333 and @SMillerDev for helping to review and test pull requests!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kiendang picture kiendang  路  3Comments

bantl23 picture bantl23  路  3Comments

gregvirgin picture gregvirgin  路  3Comments

ralexx picture ralexx  路  4Comments

oli-laban picture oli-laban  路  3Comments