Homebrew-cask: CI Issues

[vitorgalvao]

CI is crapping itself again. Making this issue so we can track the problems.

• [x] Error: Calling brew pull is deprecated! Use hub checkout instead. (example)
• [x] appcast at URL '{{SOMETHING}}' offline or looping (example).
• [x] Error: undefined method any_version_installed? (example)
• [x] Error: Calling Formula#installed? is deprecated! Use Formula#latest_version_installed? (or Formula#any_version_installed? ) instead.(example)

[ran-dall]

I’ve been meaning to fix GitHub Actions. I already have a fix for it. I’ll set it up and push it this morning.

Sent from my iPhone

On Jun 9, 2020, at 6:32 AM, Vítor Galvão [e-mail] wrote:


CI is crapping itself again. Making this issue so we can track the problems.

Error: Calling brew pull is deprecated! Use hub checkout instead. (example)
appcast at URL '{{SOMETHING}}' offline or looping (example).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[vitorgalvao]

I already have a fix for it.

Thank you!

I was under the impression you had already mentioned the brew pull issue and had fixed it, but didn’t find it in a quick search. Don’t forget it needs to apply to all repos. We have a Workflow to sync it between repos, but I’m unsure of how well it works.

[ran-dall]

@vitorgalvao Noted. Do you know if there is there a way to test out the CI modifications?

[vitorgalvao]

Do you know if there is there a way to test out the CI modifications?

I think it works if you make a PR but don’t merge (i.e. you can keep iterating on the PR itself until it passes).

[ran-dall]

84053

[ran-dall]

I'll do Travis next...

[ran-dall]

84058

[ran-dall]

That last one, I made comments on https://github.com/Homebrew/homebrew-cask/pull/83730#issuecomment-639769767.

I'm pretty sure I referenced something that doesn't exist?

[ran-dall]

@vitorgalvao I set them for you to review. If they're correct, I can run the workflow. I found it.

[chriscn]

Thought this would fix it, but no. I'll close my PR and let you guys do this. https://github.com/Homebrew/homebrew-cask/pull/84101

[fanninpm]

FYI, brew pull hasn't been completely purged.

[vitorgalvao]

@fanninpm That PR was made before any fix was merged.

[danielbayley]

@vitorgalvao I'm getting the "appcast at URL '{{SOMETHING}}' offline or looping" error when running brew cask audit --appcast locally on my machine also… Is this related?

Also, I'm seeing "Cask '{{SOMETHING}}' definition is invalid: invalid depends_on macos: value: >= :mavericks" CI errors in PRs… Presumably, this is another symptom?

[reitermarkus]

@danielbayley, the fix is not a stable release yet, that's why you are still seeing that error locally.

[vitorgalvao]

Also, I'm seeing "Cask '{{SOMETHING}}' definition is invalid: invalid depends_on macos: value: >= :mavericks" CI errors in PRs… Presumably, this is another symptom?

No, that’s unrelated. That’s due to us still having the (quite broken) system of keeping a cask copy from install time and not failing well when it becomes unreadable. Homebrew just dropped support for pre-Yosemite, so it might happen a lot.

Do https://github.com/Homebrew/homebrew-cask/issues/58046.

[danielbayley]

Thanks @vitorgalvao!

[fanninpm]

I'm assuming this is unrelated/irrelevant? (I found it in the Actions tab, and I don't know if it does anything important.)

[vitorgalvao]

Thank you @ran-dall for the fast action, and @reitermarkus for the reviews.

[vitorgalvao]

@ran-dall I see you added another one and are keeping track. Carry on, then!

[SeekingMeaning]

For Calling Formula#installed? is deprecated audit seems to mistake Cask#installed? for Formula#installed?