Home: VS; Running the restore command when Restore is disabled displays a confusing message

[tmat]

Details about Problem

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe): VS UI

VS version (if appropriate): 15.3.0 Preview 6 (26725.2.d14rel)

OS version (i.e. win10 v1607 (14393.321)): 10.0.15063

Detailed repro steps so we can see the same problem

1. Disable auto-restore in VS options:

1. Create a new .NET Core Lib.

As expected, a few errors are reported:
"The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)"

1. Run command "Restore NuGet packages" from Solution context menu

Packages are not restored, above errors are still displayed.

Package Manager output window claims all is restored:

All packages are already installed and there is nothing to restore.
Time Elapsed: 00:00:00.0067942
========== Finished ==========

Edit [nikolev]

This is the expected behavior of restore, but the message is confusing.
The message should at least be updated.

[tmat]

/cc @srivatsn

[mishra14]

cc: @nkolev92 @emgarten

[jainaashish]

@tmat this option doesn't disable auto-restore instead it disables restore itself, so what ever you're seeing is the right behavior. We don't have any option to only disable auto-restore as of now.

[tmat]

@jainaashish I see. Then either "Restore NuGet packages" should show a message that nuget package restore is disabled, or override the setting.

[nkolev92]

@tmat
I've updated the original issue/name.
Thanks for creating this.

[zhili1208]

Fixed in https://github.com/NuGet/NuGet.Client/commit/e02233b8872ec0769fe9836d60d8c48900655bb3