Home: Honor WarningsNotAsErrors

[natemcmaster]

We use TreatWarningsAsErrors=true. We want NuGet warnings to appear, but not to fail build. The concept of NoWarn is too strong as it suppresses them completely, but we still want to be aware of the issue. IMO the best property for this (that CSC also uses) is WarningsNotAsErrors, a list of warnings that should not cause errors even if TreatWarningsAsErrors is enabled.

Scenario:

<Project Sdk="Microsoft.NET.Sdk">
    <ItemGroup>
        <PackageReference Include="Moq" Version="4.7.1" />
    </ItemGroup>
    <PropertyGroup>
        <TargetFramework>netcoreapp2.0</TargetFramework>
        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <WarningsNotAsErrors>$(WarningsNotAsErrors);NU1603</WarningsNotAsErrors>
    </PropertyGroup>
</Project>

cc @emgarten

[anangaur]

@natemcmaster I am just wondering, why is this not exposed in the UI. IMO this would be the common scenario. Users will start with treating all warnings as errors and then as they understand the warnings from their project, either suppress them completely (possible in UI by "Suppress warnings" OR list them as warnings not treated as errors (WarningsNotAsErrors). May be in the properties UI we should have an option under Treat warnings as errors:
All except <Textbox>

Current properties UI for reference:

[natemcmaster]

+1 Would be cool if the VS folks could expose this in UI. This property has been a well-known option in the compiler for years. (see Microsoft.CSharp.Core.targets)

[natemcmaster]

Requested: https://github.com/dotnet/project-system/issues/2409

[mishra14]

Tagging @rrelyea for triage request.

[mishra14]

Closing as there has been no customer traction on this.

[mishra14]

Received another request. Reopening this issue for future.

[rizi]

Any update on this, it would be great if WarningsNotAsErrors a honored by NuGet.

[sadjadbp]

For now I'm using in PropertyGroup

<NoWarn>NU1701</NoWarn>

specified here

or better yet transitive warning properties explained here