hledger sets `nix enabled` to false by default

[cdepillabout]

The stack.yaml file in the root of the repo sets nix.enabled to false.

This makes builds on NixOS fail by default.

Normally, to use stack on NixOS, you add nix.enabled to ~/.stack/config.yaml. However, with nix.enabled set to false in hledger's stack.yaml, the settings in ~/.stack/config.yaml are ignored.

Ideally, nix.enabled would not be set in hledger's stack.yaml file so that stack would fall back to the nix.enabled setting specified in ~/.stack/config.yaml.

[simonmichael]

Thanks for the report. @efx, any thoughts ? I'm not finding discussion of 6bd86f9.

[simonmichael]

I assume this affects http://hledger.org/download.html -> B, C but not A.

[cdepillabout]

I think it was added here, but there doesn't seem to be any discussion as to why nix.enabled is set to false (instead of just not specified).

[efx]

IIRC, we set this to false so that the stack installer wouldn't default to using nix, but you could opt in. based on what @cdepillabout points out, I think it is safe to remove and just document that preferred approach:

Ideally, nix.enabled would not be set in hledger's stack.yaml file so that stack would fall back to the nix.enabled setting specified in ~/.stack/config.yaml.

[simonmichael]

What docs are needed ? What were the circumstances under which stack installer would default to using nix ?

[efx]

Maybe they are not needed. I think you need to have the nix enabled set to true in your per user stack config. Otherwise, you have to pass --nix to stack install for it to be enabled.

[simonmichael]

Ok, the current PR sounds good to me. Thanks!