History: window.sessionStorage cannot be used if cookies are disabled

Created on 26 Dec 2016 · 6Comments · Source: ReactTraining/history

Duplicate of #397, this time with code.

I created https://github.com/andi5/history/tree/session-storage-not-available , but I do not know how to create a pull request against a not-yet-existing v3.x branch.

Similar to #215, but the try-catch-blocks added there does not cover all the cases.

Reproduction:

use google Chrome (v55.0.2883.87 atm)
block cookies for all websites
visit any page that uses DOMStateStorage.(read|save)State from history v3.2.1
=> Uncaught DOMException: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.

"sessionStorage" in window would simply return true, whereas using window.sessionStorage throws the exception from above. The code does so without try-catch.

Source

andi5

👍2

Most helpful comment

We are not using history directly, but rather through dependencies:

https://github.com/ReactTraining/react-router/releases does not offer a stable release using history >= 4
https://github.com/taion/react-router-scroll/releases does not offer any release using history >= 4

These are not dependencies we would like to reimplement or experiment with. Instead we are waiting for them to update or hope that history 3.x will be maintained in the meanwhile.

andi5 on 27 Dec 2016

👍4

All 6 comments

What's stopping you from upgrading to 4.x? I'd rather not maintain a 3.x branch if we can avoid it. AFAICT, you're the first person who's asked for it.

mjackson on 27 Dec 2016

We are not using history directly, but rather through dependencies:

https://github.com/ReactTraining/react-router/releases does not offer a stable release using history >= 4
https://github.com/taion/react-router-scroll/releases does not offer any release using history >= 4

These are not dependencies we would like to reimplement or experiment with. Instead we are waiting for them to update or hope that history 3.x will be maintained in the meanwhile.

andi5 on 27 Dec 2016

👍4

I also faced this issue. Safari and Opera also throw an exception if cookies are disabled.
It's a bit rare situation when the user disables cookies and usually, developers don't check their code in browsers with disabled cookies.
As far as I know it could be fixed by replacing if (window.sessionStorage) with if ('sessionStorage' in window') or wrapping the whole condition in try/catch block.