Hhvm: Support composer in PHP7 mode

Created on 6 Jun 2017  路  3Comments  路  Source: facebook/hhvm
  • [x] RecursiveDirectoryIterator/SplFileInfo/dirname() throws an exception
  • [x] Add to HHVM test suite
  • [x] fix new FilesystemIterator($spl_file_info)
  • [x] fix bad tar checksum calculation: phardata implementation thought that unpack('C*') gave single-char strings, but it actually gives uint8s; phardata implementation then passes them to ord() which complains
php7 incompatibility
Source
picture fredemmott
👍2

Most helpful comment

working on that

picture mofarrell on 8 Jun 2017
❤3

All 3 comments

All done, hopefully will be backported to 3.20.2

fredemmott picture fredemmott on 8 Jun 2017

working on that

mofarrell picture mofarrell on 8 Jun 2017
❤3

This issue is needed, because *WE ARE NOT IN A PHP5 WORLD ANY LONGER.

The HHVM team, and Facebook Corp., need to be galvanized to committing to stay compatible with PHP7 or they need to break all pretenses and start marking Hack Language as its own thing.

Otherwise, once all PHP5 code is collecting dust, relatively soon, all of your, my, and their HHVM efforts will have been in vain!

Hopefully this PR is a wakeup call!

hopeseekr picture hopeseekr on 9 Jun 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

octmoraru picture octmoraru  路  5Comments
HRMsimon picture HRMsimon  路  4Comments
ahmadazimi picture ahmadazimi  路  7Comments
leetwiz picture leetwiz  路  7Comments
doublecompile picture doublecompile  路  3Comments