HeroModifiers not applied

Created on 10 Dec 2017  Â·  7Comments  Â·  Source: HeroTransitions/Hero

OS: _iOS 11_
Device tried: _iPhone 8 Simulator, iPhone 6 Simulator, iPhone 7 (real device)_
Hero install: _pod "Hero"_
Issue:
Hero animations work great but seems that heroModifiers are not applied. I tried with a custom app and with HeroExamples app with same result.

Just to be clear:

  • on the HeroExample app in the MusicPlayer storyboard I set
    scale(6.5) translate(600, 0) on the play button in storyboard modifiers but nothing changes: button only translates to final position. No scale and no translation at given point.

  • on custom app simply added 2 views in 2 viewControllers (same heroId and Hero enabled) and set a fade + scale animation and nothing changes: views translate on correct position but modifiers are not applied.

Am I missing something?...

bug? need info

Most helpful comment

I have the same issue! This is my code in viewDidLoad method:

     isHeroEnabled = true
     poiDistanceLabel.isHeroEnabled = true
     poiDistanceLabel.heroID = "poiDistanceLabel"
     poiDistanceLabel.heroModifiers = [.fade]
     poiNameLabel.isHeroEnabled = true
     poiNameLabel.heroID = "poiNameLabel"
     poiNameLabel.heroModifiers = [.fade] 
     goButton.isHeroEnabled = true
     goButton.heroID = "goButton"
     goButton.heroModifiers = [.fade]

Where am I wrong?

All 7 comments

I have the same issue! This is my code in viewDidLoad method:

     isHeroEnabled = true
     poiDistanceLabel.isHeroEnabled = true
     poiDistanceLabel.heroID = "poiDistanceLabel"
     poiDistanceLabel.heroModifiers = [.fade]
     poiNameLabel.isHeroEnabled = true
     poiNameLabel.heroID = "poiNameLabel"
     poiNameLabel.heroModifiers = [.fade] 
     goButton.isHeroEnabled = true
     goButton.heroID = "goButton"
     goButton.heroModifiers = [.fade]

Where am I wrong?

Any news about this issue?

I'm also experiencing this. A really simple example with two view controllers. Animation of views by setting the heroID's is working well. But when setting a modifier on a UIView in the target view controller nothing happens. Tried both in story board and in code in target view controller viewDidLoad().

I've been replicating the views in both ViewControllers in order to animate them as "matched items". It's an ugly workaround, indeed.

Does this issue still occur with the latest releases?

@kuyazee Yes, it's still happening. I am unable to replicate the "Usage Example 1" in a brand-new project. Every view animates correctly — except the white view, which contains Hero Modifiers.

@gabrieldluca I guest this issue is still happening. Do u have any solution for this. I want to apply spring modifier but not work.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

TofPlay picture TofPlay  Â·  4Comments

joeljfischer picture joeljfischer  Â·  3Comments

LucaGalaxy picture LucaGalaxy  Â·  4Comments

dimabiserov picture dimabiserov  Â·  3Comments

brendan-guegan-orange picture brendan-guegan-orange  Â·  4Comments