Hey y'all,
Congrats on open-sourcing Hermes!
Are you planning on providing precompiled hermes binaries for various platforms? If you are, we'd be happy to add hermes support to jsvu. This would make it easier for folks to casually play around with a recent hermes binary without having to clone + sync + build from source every time.
If not, that's cool too. Figured I'd ask :)
Cheers,
Mathias
We already provide binaries for macOS, Linux and Windows (all x86_64) through GitHub releases and NPM.
Is that what you're looking for, or do you have other platforms in mind?
That's helpful, thanks!
https://github.com/GoogleChromeLabs/jsvu/pull/74 adds hermes support to jsvu, based on the following assumptions:
jsvu-supported platforms (i.e. mac64, linux32, linux64, win32, win64), hermes only provides only mac64, linux64, and win64 builds.['dist-tags'].latest field in https://registry.npmjs.org/hermes-engine always points to the latest available Hermes version number.If any of these assumptions seem likely to change in the future, please let us know so we can come up with an alternate approach.
Along the way, I noticed that the npm tarballs (e.g. https://registry.npmjs.org/hermesvm/-/hermesvm-0.1.0.tgz) do not contain the DLLs for the Windows version. The GitHub tarballs do. Let me know if you'd like me to file this as a separate issue.
Hey just noticed that the tools from https://github.com/facebook/hermes/blob/master/doc/BuildingAndRunning.md#other-tools are not included in the prebuilt binaries. Would be awesome if you could add them to a release 馃槃
@mathiasbynens Thanks for noticing! This issue is fine.
The NPM ICU dll issue was fixed in 02ec02af539, though it still depends on the MSVC++2015 Redistributable though. All future NPM releases should include them, as well as the precompiled binaries.
Most helpful comment
Hey just noticed that the tools from https://github.com/facebook/hermes/blob/master/doc/BuildingAndRunning.md#other-tools are not included in the prebuilt binaries. Would be awesome if you could add them to a release 馃槃