Helmfile: helm tillerless does not accept sane arguments

Created on 18 Jun 2019  路  4Comments  路  Source: roboll/helmfile

When running helm in tillerless mode (recommended) you need to set sane defaults to avoid issues. The helm tiller plugin illustrates this nicely https://github.com/rimusz/helm-tiller/blob/master/scripts/tiller.sh#L5. Obviously secret storage and max history is important if you care about security and stability in your cluster. Therefore we should probably allow people to pass in a map of arguments to pass to tiller when starting in tillerless mode easily?

Most helpful comment

@willejs Good point!

I'd gladly accept PRs that enhances the config syntax to accept respective tiller args per release, and under helmDefaults:

  • tillerStorage
  • tillerHistoryMax

I don't think we need other options.

Especially for tiller port and tiller probe port, I believe they should be computed automatically to not collide, while removing the restriction of 1 concurrency when tillerless is enabled #694

All 4 comments

@willejs Good point!

I'd gladly accept PRs that enhances the config syntax to accept respective tiller args per release, and under helmDefaults:

  • tillerStorage
  • tillerHistoryMax

I don't think we need other options.

Especially for tiller port and tiller probe port, I believe they should be computed automatically to not collide, while removing the restriction of 1 concurrency when tillerless is enabled #694

Sounds good @mumoshu I will put together a pr. Sorry i started the issue to track this and make everyone aware whats missing and meant to say i will have a go at improving it. Thanks for the lightening fast feedback!

In addition to that,

for tiller port and tiller probe port, I believe they should be computed automatically to not collide

But perhaps we'd want tillerPortMin and tillerPortMax and eventually tillerPortBlacklist to instruct helmfile to use available ports for tiller. Alternatively we can automate it by trying to bind the port beforehand, so that we can decide the port is available for use by tiller.

...But that's an another story and I believe it isn't a must-have for the first impl.

Was this page helpful?
0 / 5 - 0 ratings