Haskell-language-server: "Remove redundant import" doesn't always work with ImportQualifiedPost

[georgefst]

{-# LANGUAGE ImportQualifiedPost #-}
{-# OPTIONS_GHC -Wall #-}

import Data.Functor qualified

leads to:

{-# LANGUAGE ImportQualifiedPost #-}
{-# OPTIONS_GHC -Wall #-}

 qualified

[georgefst]

Actually, this looks like a GHC SrcLoc bug. See ghc -ddump-parsed-ast. Will report upstream.

[ndmitchell]

@georgefst can you include the link here when you do. CC @shayne-fletcher (the Ghcide guts of HLS and the ImportQualifiedPost were written by the same people at the same time)

[shayne-fletcher]

@georgefst , @ndmitchell thanks for alerting me. Yes, I see the problem. @georgefst please assign me the bug

[georgefst]

https://gitlab.haskell.org/ghc/ghc/-/issues/19014

[shayne-fletcher]

Submitted an MR fixing this https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4552.

[shayne-fletcher]

The fix has landed on GHC master and marked as needing back porting to 8.10.3 and 9.0.1 🤞

[shayne-fletcher]

The fix has landed on GHC master and marked as needing back porting to 8.10.3 and 9.0.1 🤞

I see that the fix was back-ported to these branches today so we are all set.