Haskell-language-server: Attach windows binaries for ghc 8.8.4

Created on 3 Aug 2020 · 24Comments · Source: haskell/haskell-language-server

As it is difficult to make ci generate those windows binaries but it is doable locally, i think we could try to attach my local windows versions.
I am gonna follow the naming conventions of the existing ones and attach them manually asap, if no one disagree.

/cc @bubba

build windows

Source

jneira

❤2

Most helpful comment

Sure, i'll upload them asap

jneira on 9 Aug 2020

❤2

All 24 comments

That would be perfect!

bubba on 3 Aug 2020

I've attached binaries in the 0.2.2 release:

I would keep this open to track the manual upload of those versions, while they are not available via ci

jneira on 4 Aug 2020

👍2

Is 8.8.2 completely unbuildable on windows?

bubba on 4 Aug 2020

it was last time i tried it but not sure it it worths the time to try it again: two minor versions released and 5 months since the last 8.8.2 stackage lts

jneira on 4 Aug 2020

👍1

@jneira I’ve kicked off the 0.3.0 pre-release, whenever you're able can you upload some windows binaries for ghc-8.8.3 and 8.8.4 at some point? I'll wait for them before untagging it as pre-release

bubba on 9 Aug 2020

👍1

Sure, i'll upload them asap

jneira on 9 Aug 2020

❤2

@bubba done!

jneira on 10 Aug 2020

Hi @jneira , @alanz has made the 0.4.0 release could you upload some binaries for those on 8.8.4 and 8.8.3 as well?

bubba on 3 Sep 2020

Sure, i uploaded 8.8.3, 8.8.4 and 8.10.2 last night

jneira on 4 Sep 2020

❤1

Can we close this?

alanz on 4 Sep 2020

Well, we will need to upload manually windows versions hard to install in a ci env.
Stackage is using 8.8.4 for lts and 8.10.2 for nightly (with a windows workaround) so there is chances that users will need them.
I would continue uploading until newer versions are released and stackage is updated to use them.

jneira on 5 Sep 2020

Oops, sorry, I thought this related to the 0.4.0 tag specifically.

alanz on 5 Sep 2020

@jneira 0.5.0 has been tagged, can you upload some binaries again whenever you're free? https://github.com/haskell/haskell-language-server/releases/tag/0.5.0

Btw, should we be also bumping hls-plugin-api to 0.5.0?

bubba on 3 Oct 2020

👍1

I did a diff between master and 0.4.1.0 and there is no differences, I will double check it just in case.

EDIT: git diff 0.5.0 hls-plugin-api-0.4.1.0 -- .\hls-plugin-api\ does show nothing

jneira on 3 Oct 2020

binaries for hls-0.5.0 already uploaded

jneira on 5 Oct 2020

❤1

@jneira can you do binaries for 0.5.1 at some point?

bubba on 11 Oct 2020

yeah, but I will not able to do it until tomorrow at night (UTC)

jneira on 11 Oct 2020

@jneira No rush, once you upload them can you uncheck the pre-release button? Thanks again as always!

bubba on 11 Oct 2020

👍1

@bubba uploaded and pre button unchecked!

jneira on 12 Oct 2020

🚀1

Added missing windows binaries for 0.6.0

jneira on 17 Nov 2020

👍1

As we added 8.10.2 to cu, that version not need to be generated locally

jneira on 2 Dec 2020

To alliviate the manual generation of binaries i popose drop support for the ghc-8.8.3 binary and only relase ghc-8.8.4.
If nobody disagree i will do it in the next release. If some user explicitly ask for it we can attach it.

jneira on 17 Dec 2020

Sounds good to me

alanz on 17 Dec 2020

Also agreed.