Haskell-ide-engine: New install.sh builds hie-8.6.3 on Windows... and fails

[bscottm]

Might want to either comment it out or make it a platform-dependent addition to the list of versions compiled.

BTW: Would also be handy to have a script that can execute the build, at least on Windows.

[fendor]

You mean, since GHC 8.6.3 does not work on windows, there should be a check/warning for it?

What kind of script? You can execute install.hs with stack install.hs.

[jneira]

Maybe the script (install.cmd) could be simply:

stack install --stack-yaml=stack-8.6.2.yaml

... cause afaik it is the last stack config that works in windows.

In general, it could be a place to put the hacks to install it in windows with the least possible friction for users.

[Anrock]

@jneira Pls no additional platform-dependant scripts. We just recently merged a PR that deleted 3 of them, because synchronizing them is a pain and most of active devs don't have windows to test.

Put everything build-related into install.hs. Proper fix for this would be an exception for Windows for 8.6.3 target that just bails early with error message, just nobody implemented it.

... cause afaik it is the last stack config that works in windows.

Nope, latest is 8.6.4.

[jneira]

@jneira Pls no additional platform-dependant scripts. We just recently merged a PR that deleted 3 of them, because synchronizing them is a pain and most of active devs don't have windows to test.

sorry for being late to the party but the project is being built with appveyor in windows, right? the script could be tested with it automatically, including a smoke test executing hie-wrapper with no error output.

it would be great to get a balance between user and dev experience

Nope, latest is 8.6.4.

In windows 10 it works but it doesnt for me in windows 7 ( see https://github.com/haskell/haskell-ide-engine/issues/1008#issuecomment-479774564)

[jneira]

@Anrock never mind, install.hs could be the right place to do the windows handling cause you can get with it almost the same behaviour of a cmd script
thanks for pointed it out

[samuelpilz]

I am currently in the process of reviewing the install-script. What feature exactly is requested here?

[alanz]

@power-fungus if the build platform is windows, building the hie-8.6.3 target should print out a warning, not build the target, but not error out, so the rest of the targets still get built.

[fendor]

Should be very similar to implement as the warning shown when you try to use a target cabal-hie-* on windows.

[samuelpilz]

I will tackle this issue in #1168.

[fendor]

Now version 8.6.3 will no longer be installed on windows.