Hangfire: Error 500 - View Dashboard Jobs

[djfoz]

Hi,

Found a minor issue when viewing a job that can cause the dashboard to return an error 500 when viewing the status of a job. It occurs when a method accepts an array of reference types, where one of the values of the array is null.

JobMethodCallRenderer.cs line 133. item.ToString() results in a null reference exception. item?.ToString() appears to fix it. Although, argumentRenderer.Render looks to already to check. So looks like it could be checking for a null ref twice.

Thanks!

[odinserj]

Nice catch, @djfoz! Would you like to create a PR with the proposed fix? Not a problem if it's checked twice, because we can't call ToString on null objects.

[djfoz]

@odinserj - Sure will do!

Thanks

[odinserj]

Looks like this bug is the latest for the 1.6.7 milestone :tada:! We'd like to make the 1.6.7 release tomorrow, could you tell me do you have time to fix this till tomorrow?

[djfoz]

@odinserj I will submit the PR within the hour.

[odinserj]

Merged, thanks again!