Handsontable: Old CSS classes are not removed after updateSettings

Created on 17 Dec 2019  Â·  3Comments  Â·  Source: handsontable/handsontable

Description


When the Handsontable has defined className property in the initialization object that CSS class later is not removed from the DOM after updating that property through updateSettings() method. This behavior is implemented in the core (https://github.com/handsontable/handsontable/blob/master/src/core.js#L1798) but doesn't work as it suggests.

Steps to reproduce

  1. Go to https://jsfiddle.net/dver40s6/;
  2. After calling updateSettings with new className value an old CSS class is not removed from the DOM.

Demo


https://jsfiddle.net/dver40s6/

Your environment

  • Handsontable version: 7.3.0
  • Browser Name and version: any
  • Operating System: any
handsontable update settings few hours Released Bug

Most helpful comment

I think that @pnowak was working on this in #6425

All 3 comments

I think that @pnowak was working on this in #6425

Fixed in #6425 and #6425. Adding to v8 release

https://jsfiddle.net/L9rmsyo2/

The issue is fixed in Handsontable v8.0.0

CDN https://cdn.jsdelivr.net/gh/handsontable/handsontable@latest/dist/handsontable.full.css
https://cdn.jsdelivr.net/gh/handsontable/handsontable@latest/dist/handsontable.full.js
NPM npm i handsontable
Release Notes https://github.com/handsontable/handsontable/releases



I highly encourage anyone to test the new version and leave some feedback.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

andrescardona picture andrescardona  Â·  3Comments

AMBudnik picture AMBudnik  Â·  3Comments

zoladkow picture zoladkow  Â·  3Comments

paulo-raca picture paulo-raca  Â·  3Comments

AMBudnik picture AMBudnik  Â·  3Comments