Handsontable: afterRowMove hook returns improper target parameter

Created on 6 Sep 2017  路  3Comments  路  Source: handsontable/handsontable

Description

Copy for #4377. Moving rows from top to bottom still don't work.

Described issue: https://github.com/handsontable/handsontable/issues/4377#issuecomment-327434062

callbacks a day or more Moving Released Bug

All 3 comments

@wszymanski looks like your newindex mapper from issue #5751 fixed this problem :)

Changes will be released soon.

Steps to reproduce:
Moving the first row after last one - target: 3 - (wrong result)
Should be a target: 2.

Demo
AMbudnik's version http://jsfiddle.net/rzs1Lcom
8.0rc version http://jsfiddle.net/aninde/kdre8Lxb/ - fixed, with a correct target: 2.

Environment
Handsontable version:8.0.0.rc
Browser Name and version: Google Chrome version 76.0.3809.100
Operating System: macOS Mojave 10.14.6

Inside #5751 was introduced a new method dragRows which works as moveRows earlier. The moveRows function has finalIndex parameter from now which works as in the description. More about changes in the PR https://github.com/handsontable/handsontable/pull/5945.

Thank you for fixing guys!

Demo 1 http://jsfiddle.net/vz0763gL/ v 8.0.0 (result in console is 2)
Demo 2 http://jsfiddle.net/2o8kbp97/ v 8.0.0 (result in console is 2).
I'm closing this issue as solved in v 8.0.0

Was this page helpful?
0 / 5 - 0 ratings

Related issues

andrescardona picture andrescardona  路  3Comments

vikashait picture vikashait  路  3Comments

korssane picture korssane  路  3Comments

zoladkow picture zoladkow  路  3Comments

jeremy-smith-maco picture jeremy-smith-maco  路  3Comments