Halflife: MOTD resolution bugged on 1440x900

[metita]

Title. (Probably on more resolutions, not tested)

1440x900 main MOTD:

1440x900 Chooseteam VGUI

I would like more testing on more resolutions so we can provide a more complete feedback.

[Maxi605]

720x480, 1280x800, 1600x1024, 1680x1050 also have this similar issue.

[afwn90cj93201nixr2e1re]

1920x1080,

1600x900

[JoelTroch]

When you made the tests, did you just changed the resolutions or did you made game restarts in-between?

[afwn90cj93201nixr2e1re]

Just changed resolution's.

[afwn90cj93201nixr2e1re]

After restart's also work's.

[Solokiller]

I checked this with 1680x1050, both windowed and fullscreen:
https://i.imgur.com/VcYmKil.png

Notably the buy menu is not affected:
https://i.imgur.com/0JuRsR6.png

The thing that all these menus have in common is that the title is a label created by the resource file.
The MOTD does create a label called serverName, but only after calling LoadControlSettings which will create non-existent controls.
The team and class menus don't create labels at all, and rely on the resource file to do so.

Since the buy menu just sets the title on the frame it doesn't have a free floating control to position.

So it seems that the label created by the resource file isn't getting the correct x value set for some resolutions.

The code responsible is in vgui2::Panel::ApplySettings, it calculates x based on screen width so that's probably where the fix is needed.

Since xpos is 0 we can rule out GetProportionalScaledValue since it would return 0 in all cases.

[sjain882]

Happens on all 16:10 aspect ratio resolutions for me

[kisak-valve]

Closing in favor of #1931.