Habitica: new design for boss damage notifications from tasks and skills

[Alys]

As stated by @Tressley at https://github.com/HabitRPG/habitica/issues/9136#issuecomment-575685571 :

"Here's a Zeplin artboard with how damage should be displayed: https://zpl.io/2p0d882

"

This design should be applied to the notification you see when you do damage to the boss by completing a task or by casting a skill (Burst of Flames, Brutal Smash).

To get an invitation to the Zeplin artboard to see the details of the design, please tell us your email address. If you don't want to post it here publicly, email [email protected] and include the URL of this issue - however post here first to claim the issue so that someone else doesn't start on it!

[cvuorinen]

I can take this one.
Email: redacted

[Alys]

@cvuorinen Awesome, thanks!

@Tressley or another staff member will send you the Zeplin invitation.

Post here if you have any questions!

[cvuorinen]

Ok, just to be clear, do you want the notification to look exactly like that on the image, or use same general styling that all other notifications use for font sizes, padding etc. and just use the text and icon like in the image? Because just setting the text and icon doesn't really look exactly like the image.

[Tressley]

@cvuorinen -- Thanks for your quick work on this! I sent an invite to the email you provided above.

As for the current design, I'm sure you've seen that most of the existing snack notifications aren't following the proper margins and padding from the Zeplin artboard. This issue only calls for implementing the boss damage notification, so using the same general styling is okay for now.

However, if you don't mind a bit of scope increase, I wanted to do a quick re-visit on the snack designs to make them display better for the various cases (they're two years old now!) Would you be interested in updating the overall snack styling if I updated the designs this week and shared them here?

[cvuorinen]

@Tressley yes, I can update the styling too while am working on this anyway :+1:

[cvuorinen]

I made a PR already for just the icon & text change. I can make another PR later for the styling.

[cvuorinen]

@Tressley that PR now closed this issue, but I can still work on the styling when you are ready with the design. (Do we need a new issue for that, or it's ok to just discus it here?)

[Tressley]

Great, thanks for your work on this. Let's move the styling to a new issue. I can create that and ping you when it's ready. 👍