Habitica: single completion Group Plan To-Do don't get marked complete in task board

[Alys]

When a Group Plan To-Do is set to "Single - Completes when any assigned user finishes" (singleCompletion) and is assigned to or claimed by a player, when that player completes it in their own task list, it moves to their own completed To-Do list but they see the message "Task not found" and the task in the Group Plan task board doesn't get marked as completed.

It is possible that this also occurs with other task types but I haven't tested.

[VickyKoblinski]

Can we change the priority of this to high? Right now I'm paying the group membership subscription for this functionality and since it's not working, I might have to go ahead and request a refund. I don't want to - I love Habitica - but my team needs this.

I'm not seeing the message "Task not found", but otherwise this description matches my issue.

[paglias]

@VickyKoblinski sorry for the delay here, we're looking into this

[paglias]

So i just tried to replicate and the todo is moved correctly to the Completed tab, but the checkbox is missing the completion mark

@VickyKoblinski is this the same thing that's happening to you? Or the task never ends in the Completed list?

[paglias]

The issue of the completed todos checkmark not being shown has been fixed in https://github.com/HabitRPG/habitica/commit/7195ac15b99b0dd969c4f2545ac097f08fc4a516

[paglias]

And we're thinking about changing the default Shared Completion to `Single

https://github.com/HabitRPG/habitica/pull/10815

[VickyKoblinski]

@paglias Not really. Actually, I'm sorry, maybe my bug is a different one. I was referred here. But my bug is similar. I'll leave it up to you if this should be a separate issue.

My issue is actually with the shared, assigned Dailies.

Steps:
1) Have a group task board
2) Create a new daily
3) Assign daily to yourself
4) Go to your normal task list
5) Check off item as complete, get experience and gold and increment streak counter
6) Go back to group task board
7) BUG Assigned task is still orange, cannot be checked, and appears incomplete to all group members. Streak is 0 (Important).

[paglias]

@VickyKoblinski thanks for the details, I'll get back to you as soon as possible regarding your issue. Thanks for your patience

@Alys regarding the original issue, do you think the changes listed at https://github.com/HabitRPG/habitica/issues/10787#issuecomment-435886923 and in the comment about that are enough to handle the problem? I've not been able to reproduce the Task not found issue (there's more discussion in Slack)

[Alys]

I'm not getting the "task not found" error now so something has fixed that, or it was an intermittent error that occurs only under certain (currently unknown) circumstances. The checkmark change sounds like it will fix the other part of the problem. I'm fine with this being closed. We can open another if needed. I'm not closing it myself now in case you want to keep using this issue for @VickyKoblinski's bug.

[paglias]

@VickyKoblinski we've discussed your report internally and it's probably due to some confusion on how dailies are meant to work in group plans.

The shared completion setting is only available for To-Dos, so it's normal that the dailies in the group plan tasks page aren't marked as completed. We're considering changing the behavior so that dailies get marked as complete as todos but right now the correct behavior is for them to remain unchecked

[VickyKoblinski]

@paglias Thank you for looking into this. I think it'd be really helpful in the present time while determining if that functionality is going to be added, is if that's made clear, both during sign up and in the UI (maybe a warning when trying to add a daily, or disabling it, or a message saying "coming soon" - right now, from a UX perspective, it appears broken).

I'd be really excited to see this added though! Thanks again :)

[SabreCat]

@VickyKoblinski Thanks for the feedback! Group Plans will get some long-due attention soon after we complete this overhaul of username functionality, so changes are coming.

[kirsty-tortoise]

See #10690 for @VickyKoblinski's issue, I think.

[paglias]

I'm going to close this one as the original issue reported at the top has been fixed, #10690 covers the dailies issue and for the switch to Single Completion as the default option there's a PR although it'll need some internal discussion