Habitica: Seasonal Shop Closed State Style Change

Created on 10 Nov 2017  路  14Comments  路  Source: HabitRPG/habitica

There current Seasonal Shop style is incorrect.

This section should be removed:

screen shot 2017-11-09 at 7 03 10 pm

The text should actually say, "The Seasonal Shop is open during Habitica's four Grand Galas."

Grand Galas should link to the Wiki page: https://habitica.fandom.com/wiki/Grand_Galas

Note that @Tressley will invite whoever decides to claim this ticket to our Zeplin so that they can have access to details about spacing and all the necessary files, so they'll need to specify which email he should invite!

help wanted medium Seasonal Shop

All 14 comments

Can I give it a shot? looks like a pretty good first issue wouldn't mind giving it a shot if someone can guide me a little [email protected]

@hextal sure! You can open a PR and ping me if you have any question

@hextal -- It looks like you were invited to Zeplin before I had a chance to get the artboard imported! You can now review the design here: https://zpl.io/VKGWjv6

hey guys im pretty lost here, im trying to figure out where to edit the js/css?
and where can i find the sprites especially for the shop_open and the background?
currently im only seeing the halloween one and i dont see where to extract the new one on zeplin although im still kinda getting used to zeplin

@hextal the css/js files are inside website/client/components: the files ending in .vue have css/js/html inside, the shop closed image can be downloaded from zeplin, click on it and on the right there should be a link to download it in svg format

Should this be marked as in progress?

I've updated the labels on this ticket!

Hello @hextal! How are you doing on this?

I'm updating the labels on this ticket to reflect that it's ready to claim!

Is this issue still needed? If so, I can do it
[email protected]

@thewilloftheshadow -- I've invited you to our Zeplin project and marked this issue as in progress for you. You can view the Zeplin artboard here: https://zpl.io/V1PQw5m

@Tressley which one of these are we using?

This one is from Zeplin:
image

This one is currently on the website:
image

@thewilloftheshadow -- You'll use the one currently on the website, the closed image state.

I think I鈥檓 going to have to let this one go for someone else. Turns out I am really really bad at front end work, and I鈥檓 going to stick to the API and server-side of things 馃槀馃槀

Was this page helpful?
0 / 5 - 0 ratings