Habitica: New Achievement and Badge: Joined a Guild

[beffymaroo]

A new achievement and badge are ready to be implemented! This should be received when a player joins their first guild. The badge image and the name/mouseover text for the user achievement page can be found here:

https://trello.com/c/F4MwDe9D/3-joined-a-guild-badge

[CooperFLe]

I can work on this one since nobody else has expressed interest 👍

[Alys]

@CooperFLe Thanks! It's yours!

[CooperFLe]

Quick question: Can someone help point me in the right direction to where I should add the check for the achievement? I was thinking of putting it in the code where a user joins a guild, but I am not sure where that happens.

[Alys]

@CooperFLe That sounds like a good place for it. It should be in the API code (not the client-side website code) so that the achievement is given regardless of whether you join a guild on the website, official mobile apps, a third-party tool, or using raw API commands.

The API documentation is at https://habitica.com/apidoc/ and you can search in there for the API route that would let you join a group. You can then search in Habitica's codebase for text from that part of the documentation to find the code that implements that API route.

Some things to note:

• The achievement should be awarded from joining a guild but not a party.
• The achievement should not be awarded more than once (i.e., the badge will never have a number on it indicating how many guilds you've joined). We don't want the badge to be achievable more than once because that would encourage some users to join as many guilds as they could find, skewing the guild membership numbers, increasing server load from sending new message notifications, and possibly encouraging spam posts in the guilds,

[CooperFLe]

I currently have it working, but the achievement only shows after you join a guild then log out and back in...

[khipkin]

@CooperFLe sounds like you need to sync the client's user with the server

[CooperFLe]

Recently there was activity on this issue "Tavern is a guild? #7431" which made me realize that the tavern is a guild according to the servers.

So I'm assuming that the tavern is a guild that all users are added to automatically. That'd explain the unexpected behavior I've been seeing trying to implement this achievement where every user is being rewarded the achievement despite not all users having joined a guild...

Just looking for someone to confirm this thought. If this is indeed the case, would I need the tavern's id to exclude it from the code that awards the achievement?

[Alys]

@CooperFLe The Tavern is stored in the database in the same way as guilds and is treated as a guild by some of the code, but users don't typically join it in the same way they join a guild (when they do join it, it's because they've found the buggy "guild" that represents the Tavern. Normally, a user won't have the Tavern's ID listed in the user's list of joined guilds. All users aren't added to it automatically.

[SabreCat]

@CooperFLe I'm going to do some work on this, as it intersects with some A/B testing I'm working on to see how we can better encourage Guild participation. I will look at your closed PR and credit you if I end up using any of your code!

[CooperFLe]

@SabreCat sounds good. Sorry I never completed this and you had to take over.