Habitica: in party members box, link and underlining are inconsistent
As reported by DStroyer (8e2cbccd-d576-4db1-9672-03cd6d2d71d7) in the Report a Bug guild:
In the party window, inside "Members", only the name of the user is linked with clickMember(member._id, true), but not the (XX HP) part, however the whole string is underlined and looks like a link. Clicking on the HP value doesn't do a thing, that was confusing for me until I saw the clickMember() thing.
This could be fixed by either reducing the underlining to be only the person's name, or by making all of the underlined text clickable.
Alys
All 15 comments
Hello, I'd like to try and fix this one. Is that alright? :)
AndrewPomorski
on 17 Sep 2016
@AndrewPomorski That would be great, thank you!
Alys
on 17 Sep 2016
I've got everything up and running. I should be done soon.
AndrewPomorski
on 21 Sep 2016
Is this still an issue?
RussWilkie
on 12 Oct 2016
@RussWilkie Yes
Alys
on 12 Oct 2016
@Alys Would it be cool if I give it a shot?
RussWilkie
on 12 Oct 2016
@AndrewPomorski Are you still working on this?
khipkin
on 12 Oct 2016
@AndrewPomorski If you're still working on this, let us know how it's going in the next day. If you've run out of free time for it, that's fine - we know how that goes! :) We'll let @RussWilkie take it on if you're not still available for it.
Alys
on 14 Oct 2016
@RussWilkie If you'd like to take this on, please do!
Alys
on 16 Oct 2016
@Alys Fixed it, how would I go about submitting my changes? Do I just push it or do you guys want a snippet of the modified code?
RussWilkie
on 17 Oct 2016
@RussWilkie Push your changes to your fork of the repository and then create a pull request.
khipkin
on 18 Oct 2016
Not seeing my addition to the list of pull requests so I'm not sure if my pull request went through successfully. If not I'll attempt another pull request.
RussWilkie
on 18 Oct 2016
Hmm I'm not seeing it either.
khipkin
on 18 Oct 2016
@RussWilkie I saw email notifications for a couple of commits you'd made, but we do need a pull request. Does the link that @khipkin provided help (https://help.github.com/articles/creating-a-pull-request/ )? Let us know if something's going wrong with that or if the instructions aren't clear.
Alys
on 19 Oct 2016
@Alys @khipkin Hello, thanks! I made the pull request again and it went through:
RussWilkie
on 19 Oct 2016
Related issues
Alys
路
4Comments
Alys
路
4Comments
Alys
路
3Comments
keccy
路
4Comments
omtigger
路
3Comments
Most helpful comment
@RussWilkie Push your changes to your fork of the repository and then create a pull request.