Habitica: Remove v2 code from /common/script

Created on 10 Sep 2016  路  6Comments  路  Source: HabitRPG/habitica

  • Some ops/fns/... were only used in v2 and can be removed (client only code must stay for now)
  • Some ops return different data if req.v2 === true, that code can be removed
help wanted minor

All 6 comments

Why on hold?

@khipkin I wanted to check that all the stuff wasn't used on the client, I've removed the on hold status

Okay cool. :smile: I would be interested in tackling this.

@khipkin sure! It's a bit boring and probably just removing code, but if you want to do it go ahead :)

A bunch of files in common/script/ops contain the following comment:
// TODO used only in client, move there?

Do you want me to deal with this too?

@khipkin no, client only code should stay where it's. We'll remove it with the redesign but for now it's needed and doesn't make sense to spend time to move it to a client that'll be rewritten

Was this page helpful?
0 / 5 - 0 ratings