Habitica: Character appears too high in avatar on profile when no pet or mount is equipped

Created on 20 Aug 2016  路  14Comments  路  Source: HabitRPG/habitica

General Info

  • UUID: 809d8b43-07a1-49ab-9bb5-ad3ba461688d
  • Browser: Firefox
  • OS: OS X El Capitan

Description

With no pet or mount equipped, my avatar character appears higher up in the profile version of my avatar than on my header, so that the profile version looks like it's floating above the ground.

screen shot 2016-08-20 at 3 57 55 pm

good first issue minor status in progress

Most helpful comment

Equipping and dequipping a pet still shows this problem in your own avatar.

All 14 comments

Confirmed. Equipping and dequipping a pet shows this clearly.

Wow that's super bizarre. Good catch!

Suggestion: [entry level coding]

I haven't looked at the code myself so I can't be sure it's entry level, but @khipkin is probably right so I'll mark it as that. If any new contributors start this but find it troublesome, you're welcome to ask questions here in the issue!

Hi, I can tackle this one.

@AndrewPomorski Thank you!

Is this still an issue?

It is still happening. @AndrewPomorski are you still working on it?

If it turns out to be not an easy fix, requiring changing only a small amount of code, we might leave this until we do an upcoming website improvement project.

I can't find this issue on the live site, was this fixed?

I also was unable to reproduce. Has this issue been fixed or should I keep digging?

Reproduced it just now in the Tavern. If you look carefully as you click different profiles, you will see it come up, ~but it's not reproducible by toggling one's own mount and viewing one's own profile.~

image

~I suspect it may be a difference between whether the user's equipped mount is null vs. undefined, or something similarly arbitrary.~ Ignore that. It's whether or not there's a pet equipped. Like in the issue title. >.<

Equipping and dequipping a pet still shows this problem in your own avatar.

Edited my post to strike out my fail.

@Alys
Is @AndrewPomorski still working on this? If not I'd like to take this task.

Was this page helpful?
0 / 5 - 0 ratings