Habitica: Challenges: "Select All" doesn't select all challenges

[camdroid]

General Info

• UUID: beb555b6-31ab-4da2-b168-0d02d4c6dda9
• Browser: Chrome 51.0.2704.106
• OS: OS X El Capitan 10.11.5 (15F34

Description

When clicking "Select All" in the Challenges view, not all challenges are actually selected.

After clicking "None":

After clicking "All":

Console Errors

Doesn't seem to be related, but this pops up when I click "All"."
Mixed Content: The page at 'https://habitica.com/#/options/groups/challenges' was loaded over HTTPS, but requested an insecure image 'http://s33.postimg.org/59bddirb3/You_Tube_logo_full_color.png'. This content should also be served over HTTPS.

[khipkin]

Weird. Maybe an off-by-1 error or something?

Here is the "All" group filter button, which calls the challenge controller's selectAll() function (here).

[Alys]

It currently shows you all the guilds that host challenges you have joined, but the select all button highlights only guilds that you are a member of.

The desired behaviour is to highlight all guilds in that list.

[IanThorp]

I will take a look at it later today. See if I can do anything to help.

[Ozzystrasza]

@IanThorp Did you get a chance to work on this? If not I will try to fix it.

[Ozzystrasza]

I could reproduce this by joining a guild then joining a challenge in that guild, then leaving the guild. Doing that also kicked me out of the challenge but the guild name still appears in the filter list and the "all" button won't select it.
Question: Should I just fix the "all" button to select that guild along with the others, even though I'm not participating in the challenge anymore(got kicked out), or should that guild stop appearing in the filter list?

[Alys]

The "all" button should be fixed so that it selects all guilds in the list.

There are other ways to be in a challenge without being in the guild, and they also cause the guild to appear in the list without being selected by the button.

Being kicked out of challenges when you leave a guild is going to be fixed in another issue.