Habitica: [API v3] Mistakes in new notification texts

Created on 14 May 2016  路  10Comments  路  Source: HabitRPG/habitica

There is now a new notification when selling items, but depending on the case, its text contains some minor mistakes:

capture d ecran de 2016-05-14 19-51-54
No space between _Pet_ and _Cub_, and _eggs_ is plural but only one can be sold at a time.

capture d ecran de 2016-05-14 19-57-18
No space between _hatching_ and _Potions_, and _Potions_ is plural but only one can be sold at a time.

Most helpful comment

Removed 2 strings and fixed the error with non english languages

All 10 comments

Found a few more new notifications that looks ... wrong:

capture d ecran de 2016-05-14 20-54-49
capture d ecran de 2016-05-14 20-54-55
capture d ecran de 2016-05-14 20-55-05

No caps for _birthday_, _greeting_ and _thankyou_, and no space in _thankyou_.

I haven't tested it on production, but buying a saddle gives notification about "buying saddle food"

Purchasing quests are missing an _a_ in _purchased_. Also, some quests titles seems odd.
capture d ecran de 2016-05-15 10-19-10
capture d ecran de 2016-05-15 10-21-38

I think we're passing the item's keys instead of translated name...

Just wanted to confirm the same behavior when _purchasing_ eggs as well (including the typo mentioned by @Blablux):
screenshot 7
screenshot 9

Just noticed the typo in _purchased_ (purchsed) on the screen shots. Is it also there on production?

@GitHubSphinx Right now there are no notifications in the live/production site, whether for confirming sale of an item or purchase of any item

When using the website in another language (tested french) the notification comes twice and in different versions for feeding pets. For purchasing the notification comes in english with the typo mentioned earlier by @GitHubSphinx and @Blablux.
screenshot 2016-05-17 15 58 12

@Alys should these new notifications removed (you purchase a ..., you sold a ...)

Removed 2 strings and fixed the error with non english languages

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Frownigami1 picture Frownigami1  路  4Comments

thebadwolfgirl picture thebadwolfgirl  路  4Comments

Alys picture Alys  路  4Comments

audiolion picture audiolion  路  4Comments

kantamablade picture kantamablade  路  4Comments