Gutenberg: core/navigation still uses useApiFetch

Created on 21 Apr 2020  路  4Comments  路  Source: WordPress/gutenberg

Describe the bug
Recently, useApiFetch was deprecated, but core/navigation block still uses it, also because of the that block is exported, it causes build problems when using the package in a standalone outside (create-react-app).

[Block] Navigation
Source
picture senadir
😄1

Most helpful comment

@senadir I believe this was rectified in #21721, can you confirm?

picture chrisvanpatten on 22 Apr 2020
🚀1 👍1

All 4 comments

@senadir I believe this was rectified in #21721, can you confirm?

chrisvanpatten picture chrisvanpatten on 22 Apr 2020
🚀1 👍1

I can't find reference to useApiFetch in master (beyond the deprecated function itself and some tests), so I'll preemptively close this.

talldan picture talldan on 22 Apr 2020
👍1

@senadir I believe this was rectified in #21721, can you confirm?

I can confirm cos I fixed it. Check the backstory and cross links on that PR to learn how and why it happened.

getdave picture getdave on 22 Apr 2020
👍1

yeah, I can see that this issue was submitted within minutes from that PR being merged, possibly why I missed it.

senadir picture senadir on 22 Apr 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

maddisondesigns picture maddisondesigns  路  3Comments
mhenrylucero picture mhenrylucero  路  3Comments
aduth picture aduth  路  3Comments
hedgefield picture hedgefield  路  3Comments
nylen picture nylen  路  3Comments